summaryrefslogtreecommitdiffstats
path: root/o3d/converter/cross/renderer_stub.cc
diff options
context:
space:
mode:
authorgman@google.com <gman@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-25 00:18:47 +0000
committergman@google.com <gman@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-25 00:18:47 +0000
commit2976fe30ed9e0454b0995456e64a5ef7ae216df8 (patch)
tree5194cf65778a90b5a277df3d635b8164da39bb50 /o3d/converter/cross/renderer_stub.cc
parentc874da66d375909e04eb2a0aba669b162c41faba (diff)
downloadchromium_src-2976fe30ed9e0454b0995456e64a5ef7ae216df8.zip
chromium_src-2976fe30ed9e0454b0995456e64a5ef7ae216df8.tar.gz
chromium_src-2976fe30ed9e0454b0995456e64a5ef7ae216df8.tar.bz2
Cleanup Renderer.
I believe there were some mis-understandings about the code. It's supposed to work StartRendering(); BeginDraw(); EndDraw(); BeginDraw(); EndDraw(); BeginDraw(); EndDraw(); FinishRendering(); To try to enforce correct usage I separated some platform dependant stuff from shared stuff and added a few flags. Also in this CL I made Texture::GetRenderSurface not require a pack. This is so I because it feels cleaner that way but also because I wanted to use surfaces without a pack to take a screenshot. Finally I put some screenshot code in for GL. Also fixed some bugs with locking textures. 1) I thought it was x, y, width, height but it's actually x1, y1, x2, y2 2) I was using width in places I should have been using mip_width Review URL: http://codereview.chromium.org/174199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24188 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'o3d/converter/cross/renderer_stub.cc')
-rw-r--r--o3d/converter/cross/renderer_stub.cc10
1 files changed, 5 insertions, 5 deletions
diff --git a/o3d/converter/cross/renderer_stub.cc b/o3d/converter/cross/renderer_stub.cc
index 333f72a..691c1ce 100644
--- a/o3d/converter/cross/renderer_stub.cc
+++ b/o3d/converter/cross/renderer_stub.cc
@@ -73,21 +73,21 @@ void RendererStub::Destroy(void) {
DCHECK(false);
}
-bool RendererStub::BeginDraw(void) {
+bool RendererStub::PlatformSpecificBeginDraw(void) {
DCHECK(false);
return true;
}
-void RendererStub::EndDraw(void) {
+void RendererStub::PlatformSpecificEndDraw(void) {
DCHECK(false);
}
-bool RendererStub::StartRendering(void) {
+bool RendererStub::PlatformSpecificStartRendering(void) {
DCHECK(false);
return true;
}
-void RendererStub::FinishRendering(void) {
+void RendererStub::PlatformSpecificFinishRendering(void) {
DCHECK(false);
}
@@ -178,7 +178,7 @@ StreamBank::Ref RendererStub::CreateStreamBank() {
return StreamBank::Ref(new StreamBankStub(service_locator()));
}
-Bitmap::Ref RendererStub::TakeScreenshot() {
+Bitmap::Ref RendererStub::PlatformSpecificTakeScreenshot() {
return Bitmap::Ref();
}