Plugin no longer makes synchronous NPAPI calls from a Windows message handler. This fixes deadlocks and slowdown in Chrome. The approach is strange. It asynchronously opens the url data:, and then invokes Tick from the finish callback. This is the simplest approach I could think of that hide widespread browser support. NPN_PluginThreadAsyncCall would be ideal but it is supported by all browsers we currently support.

Review URL: http://codereview.chromium.org/149415

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20517 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 3 insertions, 10 deletions

diff --git a/o3d/core/cross/client.cc b/o3d/core/cross/client.cc
index e494f5d..e0fec9e 100644
--- a/o3d/core/cross/client.cc
+++ b/o3d/core/cross/client.cc
@@ -372,18 +372,11 @@ void Client::ClearPostRenderCallback() {
   post_render_callback_manager_.Clear();
 }
 
-void Client::SetRenderOnDemandCallback(
-    RenderOnDemandCallback* render_on_demand_callback) {
-  render_on_demand_callback_manager_.Set(render_on_demand_callback);
-}
-
-void Client::ClearRenderOnDemandCallback() {
-  render_on_demand_callback_manager_.Clear();
-}
-
 void Client::Render() {
   if (render_mode() == RENDERMODE_ON_DEMAND) {
-    render_on_demand_callback_manager_.Run();
+    if (renderer_.IsAvailable()) {
+      renderer_->set_need_to_render(true);
+    }
   }
 }