diff options
| author | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-04 01:53:07 +0000 |
|---|---|---|
| committer | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-04 01:53:07 +0000 |
| commit | ca87af8d86675f09d36d34c70ebbe2689ba8c183 (patch) | |
| tree | d15dfd16e00e81c768b53f07512853ce9b90f41d /o3d/core | |
| parent | 37f20cf70515a6cdf930f0ed64a2aa16feb2df53 (diff) | |
| download | chromium_src-ca87af8d86675f09d36d34c70ebbe2689ba8c183.zip chromium_src-ca87af8d86675f09d36d34c70ebbe2689ba8c183.tar.gz chromium_src-ca87af8d86675f09d36d34c70ebbe2689ba8c183.tar.bz2 | |
Merge 120450 - Revise logic to show the first-run bubble at the first appropriate opportunity.
Add static function FirstRunBubbleLauncher::ShowFirstRunBubbleSoon.
A FirstRunBubbleLauncher instance acts as a NotificationObserver and manages its own lifetime.
Show the bubble on the first NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME when conditions permit.
Also, make NTPLoginHandler::HandleLoginMessageSeen set the new NewTabUI::showing_sync_bubble_.
The bubble will be delayed if:
A) The First-Run Bubble has already been shown.
B) The Sync Promo is being shown.
C) The NTP Sync Promo Bubble will be shown.
D) A Global Error Bubble is pending.
Later attempts to show the bubble may succeed.
The bubble shows as expected on Win/Mac/Gtk first runs:
-When the sync promo is not shown.
-On the first new tab/window/navigation ignoring the sync promo.
-On clicking "Skip for now" from the sync promo.
-On the first new tab/window/navigation after the "Sign in" NTP sync promo bubble.
BUG=100299,107005
TEST=Ensure the first-run bubble shows when expected; but not with the sync promo, ntp sign-in sync promo bubble, with global errors, nor ever shown a second time (without the --first-run commandline argument).
Review URL: https://chromiumcodereview.appspot.com/9288049
TBR=msw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9317106
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120452 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'o3d/core')
0 files changed, 0 insertions, 0 deletions