diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-06 02:56:40 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-06 02:56:40 +0000 |
| commit | 6e713f08e972d4b7cf730c83a53345a4b53e1262 (patch) | |
| tree | 8610870fa23eb1ab6a0693581487ef2d7d65e026 /o3d/plugin | |
| parent | 7bff8ce11c4c3833d0b6df245d9269a201995df4 (diff) | |
| download | chromium_src-6e713f08e972d4b7cf730c83a53345a4b53e1262.zip chromium_src-6e713f08e972d4b7cf730c83a53345a4b53e1262.tar.gz chromium_src-6e713f08e972d4b7cf730c83a53345a4b53e1262.tar.bz2 | |
Make sure the socket is deleted when ConnectJob times out.
It's benign since ClientSocketPoolBase has a scoped_ptr that will delete it anyway, but it hits a DCHECK since ConnectJob::ReleaseSocket() should return NULL when the ConnectJob encountered an error.
Update TestConnectJobDelegate to call ConnectJob::ReleaseSocket() and EXPECT on its value.
Replicate the ConnectJob tests for the late binding case (doesn't add any extra coverage since we're not executing ClientSocketPoolBase code, just ConnectJob, but this way I don't accidentally delete necessary tests when I delete all the old tests after switching over completely to late binding).
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/160664
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22580 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'o3d/plugin')
0 files changed, 0 insertions, 0 deletions