diff options
| author | apatrick@google.com <apatrick@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-10 22:25:07 +0000 |
|---|---|---|
| committer | apatrick@google.com <apatrick@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-10 22:25:07 +0000 |
| commit | 804a44b4f3d42d486850e35ac1070acee5abf754 (patch) | |
| tree | 86c17041f1298ab6355189be9bfd6399b2786774 /o3d/tests/selenium | |
| parent | 2fe9b6c8af6f0c83a0b9298a8f3b1e9468e863bf (diff) | |
| download | chromium_src-804a44b4f3d42d486850e35ac1070acee5abf754.zip chromium_src-804a44b4f3d42d486850e35ac1070acee5abf754.tar.gz chromium_src-804a44b4f3d42d486850e35ac1070acee5abf754.tar.bz2 | |
Fixed some issues in the V8 bridge. It wasn't using HandleScopes correctly. There seems to be an issue resizing V8 arrays. Whenever the bridge resized a V8 array, V8 would later crash. I changed the bridge to avoid resizing V8 arrays.
Review URL: http://codereview.chromium.org/118531
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18097 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'o3d/tests/selenium')
| -rw-r--r-- | o3d/tests/selenium/javascript_unit_test_list.txt | 2 | ||||
| -rw-r--r-- | o3d/tests/selenium/sample_list.txt | 2 | ||||
| -rw-r--r-- | o3d/tests/selenium/tests/v8-test.html | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/o3d/tests/selenium/javascript_unit_test_list.txt b/o3d/tests/selenium/javascript_unit_test_list.txt index 15a08235..7d49105 100644 --- a/o3d/tests/selenium/javascript_unit_test_list.txt +++ b/o3d/tests/selenium/javascript_unit_test_list.txt @@ -63,7 +63,7 @@ small math-test small features-test except(*iexplore) small quaternion-test # TODO Temporarily removing until V8 bug is fixed -#small v8-test +small v8-test small init-status-test small quaternion-test small base-test diff --git a/o3d/tests/selenium/sample_list.txt b/o3d/tests/selenium/sample_list.txt index 5759e8d..44bcfcd 100644 --- a/o3d/tests/selenium/sample_list.txt +++ b/o3d/tests/selenium/sample_list.txt @@ -69,7 +69,7 @@ medium 2d screenshot pdiff_threshold(41200) medium animation large animated-scene screenshot timeout(45000) pdiff_threshold(200) -#large beachdemo/beachdemo screenshot timeout(120000) pdiff_threshold(1900) downsample(1) except(*iexplore) +large beachdemo/beachdemo screenshot timeout(120000) pdiff_threshold(1900) downsample(1) except(*iexplore) medium canvas screenshot pdiff_threshold(4700) pdiff_threshold_mac(14600) medium canvas-fonts screenshot pdiff_threshold(1100) pdiff_threshold_mac(21900) medium canvas-texturedraw diff --git a/o3d/tests/selenium/tests/v8-test.html b/o3d/tests/selenium/tests/v8-test.html index fa8173f..c331b52 100644 --- a/o3d/tests/selenium/tests/v8-test.html +++ b/o3d/tests/selenium/tests/v8-test.html @@ -319,7 +319,7 @@ g_suite.testV8CanInvokeBrowserConstructor = function() { g_suite.testV8ReceivesExceptionOnInvokingUndefinedConstructor = function() { var v8f = window.g_plugin.eval( 'function(f) { try { new f(); } catch(e) { return e; } }'); - g_test.assertEquals("TypeError: undefined is not a constructor", + g_test.assertEquals("TypeError: undefined is not a function", v8f(undefined).toString()); }; |