summaryrefslogtreecommitdiffstats
path: root/o3d
diff options
context:
space:
mode:
authorgman@google.com <gman@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-21 20:41:01 +0000
committergman@google.com <gman@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-21 20:41:01 +0000
commitd1868637ceb9def78abc10b10c55f1642c6c6971 (patch)
treead337c38e853ce19fb97384b2df8d53baa263b87 /o3d
parenta7f06bab72bb99c9331f8771df68bf069274d511 (diff)
downloadchromium_src-d1868637ceb9def78abc10b10c55f1642c6c6971.zip
chromium_src-d1868637ceb9def78abc10b10c55f1642c6c6971.tar.gz
chromium_src-d1868637ceb9def78abc10b10c55f1642c6c6971.tar.bz2
Delete bad sleep based tests
If you need the tests, refractor them to follow the guidelines instead of having them fail intermittently http://big.corp.google.com/~joejoejoe/testing/2008/05/episode-90-sleeping-synchronization_27.html Review URL: http://codereview.chromium.org/159117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21209 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'o3d')
-rw-r--r--o3d/statsreport/metrics_unittest.cc21
1 files changed, 0 insertions, 21 deletions
diff --git a/o3d/statsreport/metrics_unittest.cc b/o3d/statsreport/metrics_unittest.cc
index db2fe29..3aea6fa 100644
--- a/o3d/statsreport/metrics_unittest.cc
+++ b/o3d/statsreport/metrics_unittest.cc
@@ -211,19 +211,6 @@ TEST_F(MetricsTest, TimingSample) {
// Should be precisely one sample in there
EXPECT_EQ(1, data.count);
- // Disable flaky tests on build server, unfortunately this reduces coverage
- // too, but it seems preferrable to breaking the build on a regular basis.
-#ifndef BUILD_SERVER_BUILD
- // Let's hope the scheduler doesn't leave us hanging more than 10 ms.
- EXPECT_GT(40, data.sum);
- // The sleep above seems to often terminate early on the build server,
- // I've observed captured times down to 18 ms, which is strange.
- // TODO: figure out whether the timer is broken or whether
- // sleep is breaking its promise, or whether e.g. we're getting different
- // walltimes on different CPUs due to BIOS bugs on the build server
- EXPECT_LT(15, data.sum);
-#endif
-
// again, this time with a non-unity count
{
TimingSample sample(&foo, 2);
@@ -237,14 +224,6 @@ TEST_F(MetricsTest, TimingSample) {
// Should be precisely two samples in there
EXPECT_EQ(2, data.count);
- // Disable flaky tests on build server, unfortunately this reduces coverage
- // too, but it seems preferrable to breaking the build on a regular basis.
-#ifndef BUILD_SERVER_BUILD
- // Let's hope the scheduler doesn't leave us hanging more than 10 ms.
- EXPECT_GT(40, data.sum);
- EXPECT_LT(15, data.sum);
-#endif
-
// now with zero count
{
TimingSample sample(&foo, 0);