diff options
| author | vitalybuka <vitalybuka@chromium.org> | 2015-08-04 16:19:02 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-04 23:20:47 +0000 |
| commit | 0bb69c7f9ab18c6e79dd607ee6ab405231964dac (patch) | |
| tree | 40b05aa3555cb0d35a95170992fdb7347d85c174 /pdf/out_of_process_instance.h | |
| parent | 2bcebfbff86ffc73ee01f58a67e15541ffa4a150 (diff) | |
| download | chromium_src-0bb69c7f9ab18c6e79dd607ee6ab405231964dac.zip chromium_src-0bb69c7f9ab18c6e79dd607ee6ab405231964dac.tar.gz chromium_src-0bb69c7f9ab18c6e79dd607ee6ab405231964dac.tar.bz2 | |
Revert of Add a scroll offset to PDF documents to account for the top material design toolbar. (patchset #7 id:120001 of https://codereview.chromium.org/1255403002/ )
Reason for revert:
This patch breaks print preview.
BUG=516829
Original issue's description:
> Add a scroll offset to PDF documents to account for the top material design toolbar.
>
> Previously the toolbar in the material design PDF UI would always cover the top
> of pages when it was first loaded or when a page was navigated to using the
> page selector. Now we ensure that a blank region is left at the very top of
> the document when it is first loaded. This is the region that the toolbar
> covers, so the document is not obscured at all. When pages are navigated to, we
> ensure that the top of the selected page is always underneath the toolbar
> so that it is not obscured. The one exception to this is when in fit-to-page
> mode which causes the page to be zoomed to cover the entire screen, ignoring
> the toolbar. This is so that users can take advantaging of filling all of the
> screen real-estate with a page when that is what they want.
>
> This is implemented by initially scrolling the document to a negative offset
> (which is equal to the toolbar height). All subsequent scrolls are relative
> to this initial scroll. A few small bugs that assumed there was no blank space
> above the first page have also been fixed.
>
> BUG=439114
>
> Committed: https://crrev.com/daad0f1f879b13c8b55797ae5ce106d382283047
> Cr-Commit-Position: refs/heads/master@{#341685}
TBR=sammc@chromium.org,tsergeant@chromium.org,raymes@chromium.org
BUG=439114
Review URL: https://codereview.chromium.org/1267553004
Cr-Commit-Position: refs/heads/master@{#341820}
Diffstat (limited to 'pdf/out_of_process_instance.h')
| -rw-r--r-- | pdf/out_of_process_instance.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/pdf/out_of_process_instance.h b/pdf/out_of_process_instance.h index 1215f19..8a3de66 100644 --- a/pdf/out_of_process_instance.h +++ b/pdf/out_of_process_instance.h @@ -333,10 +333,6 @@ class OutOfProcessInstance : public pp::Instance, // The background color of the PDF viewer. uint32 background_color_; - // The blank space above the first page of the document reserved for the - // toolbar. - int top_toolbar_height_; - DISALLOW_COPY_AND_ASSIGN(OutOfProcessInstance); }; |