diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-09 22:24:42 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-09 22:24:42 +0000 |
| commit | 6487f72254a606f3b08b836398feef933830d71b (patch) | |
| tree | 73a15d240b2f1adefef5f90f7e7d1ac85f49f261 /pdf/out_of_process_instance.h | |
| parent | 25063816c83ae8d9d2d31d706a1a9453032731ae (diff) | |
| download | chromium_src-6487f72254a606f3b08b836398feef933830d71b.zip chromium_src-6487f72254a606f3b08b836398feef933830d71b.tar.gz chromium_src-6487f72254a606f3b08b836398feef933830d71b.tar.bz2 | |
Fixes for re-enabling more MSVC level 4 warnings: pdf/ edition
This contains fixes for the following sorts of issues:
* Signedness mismatch
This relies on https://codereview.chromium.org/376003003 to make FPDF_FillRect()
take a 32-bit value for the color in order to make the changes here as simple
and clean as possible.
This also contains a few other cleanups to make code simpler or more consistent.
BUG=81439
TEST=none
Review URL: https://codereview.chromium.org/372273005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282146 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'pdf/out_of_process_instance.h')
| -rw-r--r-- | pdf/out_of_process_instance.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/pdf/out_of_process_instance.h b/pdf/out_of_process_instance.h index f1f8862..c001435 100644 --- a/pdf/out_of_process_instance.h +++ b/pdf/out_of_process_instance.h @@ -159,7 +159,7 @@ class OutOfProcessInstance : public pp::Instance, int GetDocumentPixelHeight() const; // Draws a rectangle with the specified dimensions and color in our buffer. - void FillRect(const pp::Rect& rect, unsigned int color); + void FillRect(const pp::Rect& rect, uint32 color); void LoadUrl(const std::string& url); void LoadPreviewUrl(const std::string& url); @@ -240,7 +240,7 @@ class OutOfProcessInstance : public pp::Instance, struct BackgroundPart { pp::Rect location; - unsigned int color; + uint32 color; }; std::vector<BackgroundPart> background_parts_; |