diff options
author | avi <avi@chromium.org> | 2015-12-21 11:49:43 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-12-21 19:50:35 +0000 |
commit | a7c09d567e2878e1e3a33e1b627a11f568cf93b4 (patch) | |
tree | d8335d4dd60b638d203945ebcecc22842a648d4b /pdf/pdfium | |
parent | 360c186bfcca1dac73ff32d90c99ec476dbe28e0 (diff) | |
download | chromium_src-a7c09d567e2878e1e3a33e1b627a11f568cf93b4.zip chromium_src-a7c09d567e2878e1e3a33e1b627a11f568cf93b4.tar.gz chromium_src-a7c09d567e2878e1e3a33e1b627a11f568cf93b4.tar.bz2 |
Switch to standard integer types in pdf/.
BUG=138542
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1533413002
Cr-Commit-Position: refs/heads/master@{#366446}
Diffstat (limited to 'pdf/pdfium')
-rw-r--r-- | pdf/pdfium/pdfium_api_string_buffer_adapter.cc | 2 | ||||
-rw-r--r-- | pdf/pdfium/pdfium_api_string_buffer_adapter.h | 4 | ||||
-rw-r--r-- | pdf/pdfium/pdfium_assert_matching_enums.cc | 1 | ||||
-rw-r--r-- | pdf/pdfium/pdfium_engine.cc | 28 | ||||
-rw-r--r-- | pdf/pdfium/pdfium_engine.h | 4 | ||||
-rw-r--r-- | pdf/pdfium/pdfium_mem_buffer_file_read.cc | 1 | ||||
-rw-r--r-- | pdf/pdfium/pdfium_mem_buffer_file_read.h | 1 | ||||
-rw-r--r-- | pdf/pdfium/pdfium_mem_buffer_file_write.h | 2 | ||||
-rw-r--r-- | pdf/pdfium/pdfium_page.cc | 1 |
9 files changed, 28 insertions, 16 deletions
diff --git a/pdf/pdfium/pdfium_api_string_buffer_adapter.cc b/pdf/pdfium/pdfium_api_string_buffer_adapter.cc index 9ac7425..e4e953a 100644 --- a/pdf/pdfium/pdfium_api_string_buffer_adapter.cc +++ b/pdf/pdfium/pdfium_api_string_buffer_adapter.cc @@ -4,6 +4,8 @@ #include "pdf/pdfium/pdfium_api_string_buffer_adapter.h" +#include <stddef.h> + #include <string> #include "base/logging.h" diff --git a/pdf/pdfium/pdfium_api_string_buffer_adapter.h b/pdf/pdfium/pdfium_api_string_buffer_adapter.h index 0005e97..7b45cbe 100644 --- a/pdf/pdfium/pdfium_api_string_buffer_adapter.h +++ b/pdf/pdfium/pdfium_api_string_buffer_adapter.h @@ -5,7 +5,9 @@ #ifndef PDF_PDFIUM_PDFIUM_API_STRING_BUFFER_ADAPTER_H_ #define PDF_PDFIUM_PDFIUM_API_STRING_BUFFER_ADAPTER_H_ -#include "base/basictypes.h" +#include <stddef.h> + +#include "base/macros.h" #include "base/numerics/safe_math.h" namespace chrome_pdf { diff --git a/pdf/pdfium/pdfium_assert_matching_enums.cc b/pdf/pdfium/pdfium_assert_matching_enums.cc index a7f6e29..2dcba54 100644 --- a/pdf/pdfium/pdfium_assert_matching_enums.cc +++ b/pdf/pdfium/pdfium_assert_matching_enums.cc @@ -2,7 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "base/basictypes.h" #include "ppapi/c/pp_input_event.h" #include "ppapi/c/private/ppb_pdf.h" #include "ppapi/c/private/ppp_pdf.h" diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc index 5287a29..0528c94 100644 --- a/pdf/pdfium/pdfium_engine.cc +++ b/pdf/pdfium/pdfium_engine.cc @@ -5,11 +5,14 @@ #include "pdf/pdfium/pdfium_engine.h" #include <math.h> +#include <stddef.h> +#include <stdint.h> #include "base/i18n/icu_encoding_detection.h" #include "base/i18n/icu_string_conversions.h" #include "base/json/json_writer.h" #include "base/logging.h" +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/numerics/safe_conversions.h" #include "base/stl_util.h" @@ -71,7 +74,7 @@ namespace { #define kHighlightColorG 193 #define kHighlightColorB 218 -const uint32 kPendingPageColor = 0xFFEEEEEE; +const uint32_t kPendingPageColor = 0xFFEEEEEE; #define kFormHighlightColor 0xFFE4DD #define kFormHighlightAlpha 100 @@ -3102,14 +3105,11 @@ void PDFiumEngine::Highlight(void* buffer, for (int y = t; y < t + h; ++y) { for (int x = l; x < l + w; ++x) { - uint8* pixel = static_cast<uint8*>(buffer) + y * stride + x * 4; + uint8_t* pixel = static_cast<uint8_t*>(buffer) + y * stride + x * 4; // This is our highlight color. - pixel[0] = static_cast<uint8>( - pixel[0] * (kHighlightColorB / 255.0)); - pixel[1] = static_cast<uint8>( - pixel[1] * (kHighlightColorG / 255.0)); - pixel[2] = static_cast<uint8>( - pixel[2] * (kHighlightColorR / 255.0)); + pixel[0] = static_cast<uint8_t>(pixel[0] * (kHighlightColorB / 255.0)); + pixel[1] = static_cast<uint8_t>(pixel[1] * (kHighlightColorG / 255.0)); + pixel[2] = static_cast<uint8_t>(pixel[2] * (kHighlightColorR / 255.0)); } } } @@ -3381,12 +3381,12 @@ void PDFiumEngine::DrawPageShadow(const pp::Rect& page_rc, // Page drop shadow parameters. const double factor = 0.5; - uint32 depth = std::max( - std::max(page_rect.x() - shadow_rect.x(), - page_rect.y() - shadow_rect.y()), - std::max(shadow_rect.right() - page_rect.right(), - shadow_rect.bottom() - page_rect.bottom())); - depth = static_cast<uint32>(depth * 1.5) + 1; + uint32_t depth = + std::max(std::max(page_rect.x() - shadow_rect.x(), + page_rect.y() - shadow_rect.y()), + std::max(shadow_rect.right() - page_rect.right(), + shadow_rect.bottom() - page_rect.bottom())); + depth = static_cast<uint32_t>(depth * 1.5) + 1; // We need to check depth only to verify our copy of shadow matrix is correct. if (!page_shadow_.get() || page_shadow_->depth() != depth) diff --git a/pdf/pdfium/pdfium_engine.h b/pdf/pdfium/pdfium_engine.h index 7d39108..3ebe68f0 100644 --- a/pdf/pdfium/pdfium_engine.h +++ b/pdf/pdfium/pdfium_engine.h @@ -5,11 +5,15 @@ #ifndef PDF_PDFIUM_PDFIUM_ENGINE_H_ #define PDF_PDFIUM_PDFIUM_ENGINE_H_ +#include <stddef.h> +#include <stdint.h> + #include <map> #include <string> #include <utility> #include <vector> +#include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/time/time.h" #include "pdf/document_loader.h" diff --git a/pdf/pdfium/pdfium_mem_buffer_file_read.cc b/pdf/pdfium/pdfium_mem_buffer_file_read.cc index b2371b4..56d7662 100644 --- a/pdf/pdfium/pdfium_mem_buffer_file_read.cc +++ b/pdf/pdfium/pdfium_mem_buffer_file_read.cc @@ -4,6 +4,7 @@ #include "pdf/pdfium/pdfium_mem_buffer_file_read.h" +#include <stddef.h> #include <string.h> namespace chrome_pdf { diff --git a/pdf/pdfium/pdfium_mem_buffer_file_read.h b/pdf/pdfium/pdfium_mem_buffer_file_read.h index 419b8c8..1c4b779 100644 --- a/pdf/pdfium/pdfium_mem_buffer_file_read.h +++ b/pdf/pdfium/pdfium_mem_buffer_file_read.h @@ -5,6 +5,7 @@ #ifndef PDF_PDFIUM_PDFIUM_MEM_BUFFER_FILE_READ_H_ #define PDF_PDFIUM_PDFIUM_MEM_BUFFER_FILE_READ_H_ +#include <stddef.h> #include <stdlib.h> #include "third_party/pdfium/public/fpdfview.h" diff --git a/pdf/pdfium/pdfium_mem_buffer_file_write.h b/pdf/pdfium/pdfium_mem_buffer_file_write.h index 619bc87..ed940f8 100644 --- a/pdf/pdfium/pdfium_mem_buffer_file_write.h +++ b/pdf/pdfium/pdfium_mem_buffer_file_write.h @@ -5,6 +5,8 @@ #ifndef PDF_PDFIUM_PDFIUM_MEM_BUFFER_FILE_WRITE_ #define PDF_PDFIUM_PDFIUM_MEM_BUFFER_FILE_WRITE_ +#include <stddef.h> + #include <string> #include "third_party/pdfium/public/fpdf_save.h" diff --git a/pdf/pdfium/pdfium_page.cc b/pdf/pdfium/pdfium_page.cc index fe1a07e..5e0b192 100644 --- a/pdf/pdfium/pdfium_page.cc +++ b/pdf/pdfium/pdfium_page.cc @@ -5,6 +5,7 @@ #include "pdf/pdfium/pdfium_page.h" #include <math.h> +#include <stddef.h> #include "base/logging.h" #include "base/strings/string_number_conversions.h" |