diff options
author | keishi <keishi@chromium.org> | 2015-01-08 21:58:01 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-01-09 05:58:40 +0000 |
commit | 39de3f06b6b69bd409c7f261ef63e2ad24df1e3a (patch) | |
tree | a3403d7a9ab9a078e6d66d09bd34ce729e01e3f6 /pdf | |
parent | 4c80f1560683212ff5116b53f2830ba53b614442 (diff) | |
download | chromium_src-39de3f06b6b69bd409c7f261ef63e2ad24df1e3a.zip chromium_src-39de3f06b6b69bd409c7f261ef63e2ad24df1e3a.tar.gz chromium_src-39de3f06b6b69bd409c7f261ef63e2ad24df1e3a.tar.bz2 |
Revert of Add print and getSelectedText functions to the OOP PDF scripting API (patchset #3 id:40001 of https://codereview.chromium.org/843463002/)
Reason for revert:
Win7 Tests fail the test PDFExtensionTest.BasicPlugin.
API Test Error in testGetSelectedText
http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/7823/steps/browser_tests/logs/BasicPlugin
Original issue's description:
> Add print and getSelectedText functions to the OOP PDF scripting API
>
> These are needed by some internal users (see the bug for more details).
> A test is added for selectAll/getSelectedText.
>
> BUG=415858
>
> Committed: https://crrev.com/7b1df224a957da8376e0ae71ab2d53dabf658b0a
> Cr-Commit-Position: refs/heads/master@{#310663}
TBR=sammc@chromium.org,raymes@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415858
Review URL: https://codereview.chromium.org/843923002
Cr-Commit-Position: refs/heads/master@{#310716}
Diffstat (limited to 'pdf')
-rw-r--r-- | pdf/out_of_process_instance.cc | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/pdf/out_of_process_instance.cc b/pdf/out_of_process_instance.cc index e0ab99a..59b0439 100644 --- a/pdf/out_of_process_instance.cc +++ b/pdf/out_of_process_instance.cc @@ -127,11 +127,6 @@ const char kJSRotateClockwiseType[] = "rotateClockwise"; const char kJSRotateCounterclockwiseType[] = "rotateCounterclockwise"; // Select all text in the document (Page -> Plugin) const char kJSSelectAllType[] = "selectAll"; -// Get the selected text in the document (Page -> Plugin) -const char kJSGetSelectedTextType[] = "getSelectedText"; -// Reply with selected text (Plugin -> Page) -const char kJSGetSelectedTextReplyType[] = "getSelectedTextReply"; -const char kJSSelectedText[] = "selectedText"; const int kFindResultCooldownMs = 100; @@ -449,11 +444,6 @@ void OutOfProcessInstance::HandleMessage(const pp::Var& message) { PostMessage(reply); } else if (type == kJSStopScrollingType) { stop_scrolling_ = true; - } else if (type == kJSGetSelectedTextType) { - pp::VarDictionary reply; - reply.Set(pp::Var(kType), pp::Var(kJSGetSelectedTextReplyType)); - reply.Set(pp::Var(kJSSelectedText), engine_->GetSelectedText()); - PostMessage(reply); } else { NOTREACHED(); } |