diff options
| author | brettw <brettw@chromium.org> | 2015-02-19 15:17:04 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-02-19 23:18:14 +0000 |
| commit | d1c719acf7db459016f425eb8018ec4208511578 (patch) | |
| tree | f5604ba0055245c0133cd5747e8a70de99b917f7 /pdf | |
| parent | 9ff250e0023b2f87e0fddd7eadbef7be3ecc3882 (diff) | |
| download | chromium_src-d1c719acf7db459016f425eb8018ec4208511578.zip chromium_src-d1c719acf7db459016f425eb8018ec4208511578.tar.gz chromium_src-d1c719acf7db459016f425eb8018ec4208511578.tar.bz2 | |
Update existing uses of /wd4267 to use the GN config
This is the size_t to integer conversion warning. Using the config prevents flag duplication and is clearer to read.
Minor updates to Win64 build, including some fixes for size_t to int conversions.
Review URL: https://codereview.chromium.org/929793006
Cr-Commit-Position: refs/heads/master@{#317162}
Diffstat (limited to 'pdf')
| -rw-r--r-- | pdf/BUILD.gn | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/pdf/BUILD.gn b/pdf/BUILD.gn index 49f49a4..0f74323 100644 --- a/pdf/BUILD.gn +++ b/pdf/BUILD.gn @@ -45,6 +45,9 @@ static_library("pdf") { "thumbnail_control.h", ] + # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. + configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] + if (pdf_engine == 0) { sources += [ "pdfium/pdfium_api_string_buffer_adapter.cc", @@ -63,10 +66,6 @@ static_library("pdf") { ] } - if (is_win) { - cflags = [ "/wd4267" ] # TODO(jschuh) size_t to int truncations. - } - deps = [ "//base", "//components/ui/zoom:ui_zoom", |