diff options
| author | estade <estade@chromium.org> | 2015-05-15 18:02:34 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-16 01:02:46 +0000 |
| commit | 8d04646294767ea1f3a7da596547b465d50cb4d1 (patch) | |
| tree | 6bd6194b6fe2ac226114f9125570bd605e9b6d42 /pdf | |
| parent | f39e5aff5aae8451a7ef190a2fc822bf80c4e30d (diff) | |
| download | chromium_src-8d04646294767ea1f3a7da596547b465d50cb4d1.zip chromium_src-8d04646294767ea1f3a7da596547b465d50cb4d1.tar.gz chromium_src-8d04646294767ea1f3a7da596547b465d50cb4d1.tar.bz2 | |
Convert JsonWriter::Write to taking a const ref for the in-param
Clearer API; flushes out a lot of unnecessary heap allocations.
depends on https://codereview.chromium.org/1129083003/
BUG=none
Review URL: https://codereview.chromium.org/1131113004
Cr-Commit-Position: refs/heads/master@{#330255}
Diffstat (limited to 'pdf')
| -rw-r--r-- | pdf/out_of_process_instance.cc | 2 | ||||
| -rw-r--r-- | pdf/pdfium/pdfium_engine.cc | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/pdf/out_of_process_instance.cc b/pdf/out_of_process_instance.cc index 8c240a6..d8188ad 100644 --- a/pdf/out_of_process_instance.cc +++ b/pdf/out_of_process_instance.cc @@ -469,7 +469,7 @@ void OutOfProcessInstance::HandleMessage(const pp::Var& message) { engine_->HasPermission(PDFEngine::PERMISSION_COPY_ACCESSIBLE); node.SetBoolean(kAccessibleCopyable, has_permissions); std::string json; - base::JSONWriter::Write(&node, &json); + base::JSONWriter::Write(node, &json); reply.Set(pp::Var(kJSAccessibilityJSON), pp::Var(json)); } PostMessage(reply); diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc index e463f15..f4df4a9 100644 --- a/pdf/pdfium/pdfium_engine.cc +++ b/pdf/pdfium/pdfium_engine.cc @@ -2434,7 +2434,7 @@ std::string PDFiumEngine::GetPageAsJSON(int index) { scoped_ptr<base::Value> node( pages_[index]->GetAccessibleContentAsValue(current_rotation_)); std::string page_json; - base::JSONWriter::Write(node.get(), &page_json); + base::JSONWriter::Write(*node, &page_json); return page_json; } |