summaryrefslogtreecommitdiffstats
path: root/ppapi/api
diff options
context:
space:
mode:
authorbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-07-22 15:49:34 +0000
committerbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-07-22 15:49:34 +0000
commitb599a9f5fcc583d9bb623a874ac5ab068d326843 (patch)
tree82c913aafe80d32ab2533aaca0e56b51308b85aa /ppapi/api
parentd4736820135edfcf780bb6d389d02ac79cf172f8 (diff)
downloadchromium_src-b599a9f5fcc583d9bb623a874ac5ab068d326843.zip
chromium_src-b599a9f5fcc583d9bb623a874ac5ab068d326843.tar.gz
chromium_src-b599a9f5fcc583d9bb623a874ac5ab068d326843.tar.bz2
Remove the requirement that keyboard events be sent in filtered mode. This
hurts some higher-performance game use cases, and probably won't help much to prevent abuse. Review URL: http://codereview.chromium.org/7481021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93641 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/api')
-rw-r--r--ppapi/api/ppb_input_event.idl17
1 files changed, 9 insertions, 8 deletions
diff --git a/ppapi/api/ppb_input_event.idl b/ppapi/api/ppb_input_event.idl
index ba4536a..6ee87a3 100644
--- a/ppapi/api/ppb_input_event.idl
+++ b/ppapi/api/ppb_input_event.idl
@@ -149,9 +149,11 @@ enum PP_InputEvent_Class {
PP_INPUTEVENT_CLASS_MOUSE = 1 << 0,
/**
- * Requests keyboard events. Keyboard events must be requested in filtering
- * mode via RequestFilteringInputEvents(). This is because many commands
- * should be forwarded to the page.
+ * Requests keyboard events. Often you will want to request filtered mode
+ * (via RequestFilteringInputEvents) for keyboard events so you can pass on
+ * events (by returning false) that you don't handle. For example, if you
+ * don't request filtered mode and the user pressed "Page Down" when your
+ * instance has focus, the page won't scroll which will be a poor experience.
*
* A small number of tab and window management commands like Alt-F4 are never
* sent to the page. You can not request these keyboard commands since it
@@ -202,9 +204,9 @@ interface PPB_InputEvent {
* Request that input events corresponding to the given input events are
* delivered to the instance.
*
- * You can not use this function to request keyboard events
- * (PP_INPUTEVENT_CLASS_KEYBOARD). You must use RequestFilteringInputEvents()
- * for this class of input.
+ * It's recommended that you use RequestFilteringInputEvents() for keyboard
+ * events instead of this function so that you don't interfere with normal
+ * browser accelerators.
*
* By default, no input events are delivered. Call this function with the
* classes of events you are interested in to have them be delivered to
@@ -256,8 +258,7 @@ interface PPB_InputEvent {
* register to receive events by calling RequestInputEvents(). In some cases,
* however, you may wish to filter events such that they can be bubbled up
* to the DOM. In this case, register for those classes of events using
- * this function instead of RequestInputEvents(). Keyboard events must always
- * be registered in filtering mode.
+ * this function instead of RequestInputEvents().
*
* Filtering input events requires significantly more overhead than just
* delivering them to the instance. As such, you should only request