diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-09 22:51:24 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-09 22:51:24 +0000 |
| commit | e2051fde97eab43065d52214fe9e9e6fc86c761e (patch) | |
| tree | 515f2c84cfcba63f5990f6c65c1986aff089fe0a /ppapi/c | |
| parent | 4b4a737b48a8ab184bc99be6a25675f565a4acbd (diff) | |
| download | chromium_src-e2051fde97eab43065d52214fe9e9e6fc86c761e.zip chromium_src-e2051fde97eab43065d52214fe9e9e6fc86c761e.tar.gz chromium_src-e2051fde97eab43065d52214fe9e9e6fc86c761e.tar.bz2 | |
Merge 144623 - Implement right-to-left text rendering in Pepper.
TEST=included
BUG=http://crbug.com/134394
Review URL: https://chromiumcodereview.appspot.com/10658037
TBR=brettw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@145768 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/c')
| -rw-r--r-- | ppapi/c/dev/ppb_font_dev.h | 20 | ||||
| -rw-r--r-- | ppapi/c/trusted/ppb_browser_font_trusted.h | 6 |
2 files changed, 23 insertions, 3 deletions
diff --git a/ppapi/c/dev/ppb_font_dev.h b/ppapi/c/dev/ppb_font_dev.h index 6ba36a6..ad85a24 100644 --- a/ppapi/c/dev/ppb_font_dev.h +++ b/ppapi/c/dev/ppb_font_dev.h @@ -3,7 +3,7 @@ * found in the LICENSE file. */ -/* From dev/ppb_font_dev.idl modified Tue Oct 11 10:01:39 2011. */ +/* From dev/ppb_font_dev.idl modified Mon Jun 25 14:54:48 2012. */ #ifndef PPAPI_C_DEV_PPB_FONT_DEV_H_ #define PPAPI_C_DEV_PPB_FONT_DEV_H_ @@ -141,11 +141,27 @@ struct PP_TextRun_Dev { struct PP_Var text; /** * Set to PP_TRUE if the text is right-to-left. + * + * When <code>override_direction</code> is false, the browser will perform + * the Unicode Bidirectional Algorithm (http://unicode.org/reports/tr9/) on + * the text. The value of the <code>rtl</code> flag specifies the + * direcionality of the surrounding environment. This means that Hebrew + * word will always display right to left, even if <code>rtl</code> is false. + * + * When <code>override_direction</code> is true, no autodetection will be done + * and <code>rtl</code> specifies the direction of the text. + * + * TODO(brettw) note that autodetection with rtl = true is currently + * unimplemented. */ PP_Bool rtl; /** * Set to PP_TRUE to force the directionality of the text regardless of - * content + * content. + * + * If this flag is set, the browser will skip autodetection of the content + * and will display all text in the direction speficied by the + * <code>rtl</code> flag. */ PP_Bool override_direction; }; diff --git a/ppapi/c/trusted/ppb_browser_font_trusted.h b/ppapi/c/trusted/ppb_browser_font_trusted.h index 080d024..c16a153 100644 --- a/ppapi/c/trusted/ppb_browser_font_trusted.h +++ b/ppapi/c/trusted/ppb_browser_font_trusted.h @@ -4,7 +4,7 @@ */ /* From trusted/ppb_browser_font_trusted.idl, - * modified Tue Feb 14 08:45:20 2012. + * modified Wed Jun 27 14:43:20 2012. */ #ifndef PPAPI_C_TRUSTED_PPB_BROWSER_FONT_TRUSTED_H_ @@ -252,6 +252,10 @@ struct PPB_BrowserFont_Trusted_1_0 { * the string. This handles complex scripts such as Arabic, where characters * may be combined or replaced depending on the context. Returns (uint32)-1 * on failure. + * + * TODO(brettw) this function may be broken. See the CharPosRTL test. It + * seems to tell you "insertion point" rather than painting position. This + * is useful but maybe not what we intended here. */ uint32_t (*CharacterOffsetForPixel)( PP_Resource font, |