diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-15 20:44:09 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-15 20:44:09 +0000 |
| commit | 47e2411daad2049c4976cc5e970a317782d6c565 (patch) | |
| tree | 934e396685172a2817700354f944a72475acccc0 /ppapi/c | |
| parent | 17cd29ad16a8cad6b1316fd5bf42f3a46c1dc78f (diff) | |
| download | chromium_src-47e2411daad2049c4976cc5e970a317782d6c565.zip chromium_src-47e2411daad2049c4976cc5e970a317782d6c565.tar.gz chromium_src-47e2411daad2049c4976cc5e970a317782d6c565.tar.bz2 | |
Add some notes to audio input.
If/when we stabilize this API we'll want to make some changes. I added some
notes so we don't forget about this stuff when the time comes.
Review URL: https://codereview.chromium.org/11275329
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168018 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/c')
| -rw-r--r-- | ppapi/c/dev/ppb_audio_input_dev.h | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/ppapi/c/dev/ppb_audio_input_dev.h b/ppapi/c/dev/ppb_audio_input_dev.h index 585ea47..276b5fa7 100644 --- a/ppapi/c/dev/ppb_audio_input_dev.h +++ b/ppapi/c/dev/ppb_audio_input_dev.h @@ -3,7 +3,7 @@ * found in the LICENSE file. */ -/* From dev/ppb_audio_input_dev.idl modified Mon Oct 29 14:40:53 2012. */ +/* From dev/ppb_audio_input_dev.idl modified Wed Nov 14 15:08:54 2012. */ #ifndef PPAPI_C_DEV_PPB_AUDIO_INPUT_DEV_H_ #define PPAPI_C_DEV_PPB_AUDIO_INPUT_DEV_H_ @@ -48,6 +48,19 @@ typedef void (*PPB_AudioInput_Callback)(const void* sample_buffer, /** * The <code>PPB_AudioInput_Dev</code> interface contains pointers to several * functions for handling audio input resources. + * + * TODO(brettw) before moving out of dev, we need to resolve the issue of + * the mismatch between the current audio config interface and this one. + * + * In particular, the params for input assume stereo, but this class takes + * everything as mono. We either need to not use an audio config resource, or + * add mono support. + * + * In addition, RecommendSampleFrameCount is completely wrong for audio input. + * RecommendSampleFrameCount returns the frame count for the current + * low-latency output device, which is likely inappropriate for a random input + * device. We may want to move the "recommend" functions to the input or output + * classes rather than the config. */ struct PPB_AudioInput_Dev_0_2 { /** |