diff options
author | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-08 17:11:41 +0000 |
---|---|---|
committer | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-08 17:11:41 +0000 |
commit | 02712874c2d623d1dd41c0b3350b769d2855b9f2 (patch) | |
tree | 7205e95c9ceb2cb33162b68621ac04d6ce0e1715 /ppapi/cpp | |
parent | 46e2912bee9e94634cf3c99c80766ea4a02a4744 (diff) | |
download | chromium_src-02712874c2d623d1dd41c0b3350b769d2855b9f2.zip chromium_src-02712874c2d623d1dd41c0b3350b769d2855b9f2.tar.gz chromium_src-02712874c2d623d1dd41c0b3350b769d2855b9f2.tar.bz2 |
Pepper: Make users of pp:NetworkMonitorPrivate less likely to leak resources.
a) Make NetworkListPrivate's constructor (that takes a PP_Resource) take
ownership of that resource.
b) Add an explicit PASS_REF to that constructor, to make its semantics clear.
TEST=PPAPI tests
Review URL: https://chromiumcodereview.appspot.com/10381002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135856 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/cpp')
-rw-r--r-- | ppapi/cpp/private/network_list_private.cc | 4 | ||||
-rw-r--r-- | ppapi/cpp/private/network_list_private.h | 3 |
2 files changed, 4 insertions, 3 deletions
diff --git a/ppapi/cpp/private/network_list_private.cc b/ppapi/cpp/private/network_list_private.cc index 84990a2..35bb66a 100644 --- a/ppapi/cpp/private/network_list_private.cc +++ b/ppapi/cpp/private/network_list_private.cc @@ -20,8 +20,8 @@ template <> const char* interface_name<PPB_NetworkList_Private>() { NetworkListPrivate::NetworkListPrivate() { } -NetworkListPrivate::NetworkListPrivate(PP_Resource resource) - : Resource(resource) { +NetworkListPrivate::NetworkListPrivate(PassRef, PP_Resource resource) + : Resource(PASS_REF, resource) { } // static diff --git a/ppapi/cpp/private/network_list_private.h b/ppapi/cpp/private/network_list_private.h index d614362..31cd9b5 100644 --- a/ppapi/cpp/private/network_list_private.h +++ b/ppapi/cpp/private/network_list_private.h @@ -9,6 +9,7 @@ #include <vector> #include "ppapi/c/private/ppb_network_list_private.h" +#include "ppapi/cpp/pass_ref.h" #include "ppapi/cpp/resource.h" namespace pp { @@ -16,7 +17,7 @@ namespace pp { class NetworkListPrivate : public Resource { public: NetworkListPrivate(); - explicit NetworkListPrivate(PP_Resource resource); + NetworkListPrivate(PassRef, PP_Resource resource); /// Returns true if the required interface is available. static bool IsAvailable(); |