diff options
| author | polina@google.com <polina@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-30 21:42:37 +0000 |
|---|---|---|
| committer | polina@google.com <polina@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-30 21:42:37 +0000 |
| commit | 917e86adc3f824f518c999dcba20bfd4cbf18a18 (patch) | |
| tree | 52fe38f61527360231c17a905015066fb5d34bba /ppapi/example | |
| parent | 9ae7b9195f0e06b64664bba52e9cc0e8b3470f56 (diff) | |
| download | chromium_src-917e86adc3f824f518c999dcba20bfd4cbf18a18.zip chromium_src-917e86adc3f824f518c999dcba20bfd4cbf18a18.tar.gz chromium_src-917e86adc3f824f518c999dcba20bfd4cbf18a18.tar.bz2 | |
Add a flag field to PP_CompletionCallback to control if the callback should
always be invoked asynchronously on success or error or skipped if the
operation can complete synchronously without blocking. Keep the default
behavior as-is until clients update their code. Bump revisions of all
interfaces that take callbacks as args. Update browser interface function
implementations and C++ layer to force callbacks if sync option is not set.
Change ppapi/tests to run tests involving callbacks with both flag options.
BUG=79376
TEST=ppapi_tests + bots
Review URL: http://codereview.chromium.org/6899055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91205 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/example')
| -rw-r--r-- | ppapi/example/example.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ppapi/example/example.cc b/ppapi/example/example.cc index 5dc3842..93696f0 100644 --- a/ppapi/example/example.cc +++ b/ppapi/example/example.cc @@ -107,7 +107,7 @@ class MyFetcher { client_ = client; pp::CompletionCallback callback = - callback_factory_.NewCallback(&MyFetcher::DidOpen); + callback_factory_.NewOptionalCallback(&MyFetcher::DidOpen); int rv = loader_.Open(request, callback); if (rv != PP_OK_COMPLETIONPENDING) callback.Run(rv); @@ -124,7 +124,7 @@ class MyFetcher { private: void ReadMore() { pp::CompletionCallback callback = - callback_factory_.NewCallback(&MyFetcher::DidRead); + callback_factory_.NewOptionalCallback(&MyFetcher::DidRead); int rv = loader_.ReadResponseBody(buf_, sizeof(buf_), callback); if (rv != PP_OK_COMPLETIONPENDING) callback.Run(rv); |