diff options
| author | yzshen@chromium.org <yzshen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-11 04:38:11 +0000 |
|---|---|---|
| committer | yzshen@chromium.org <yzshen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-11 04:38:11 +0000 |
| commit | 63e56c83c4689dd0dfcef4b40e5fa8ef135e86f5 (patch) | |
| tree | d81f77cc66e02be05332afe49ff77937b9207bf1 /ppapi/generators | |
| parent | bc71f4e91c7117d38644fa77d179fca23f1de5fb (diff) | |
| download | chromium_src-63e56c83c4689dd0dfcef4b40e5fa8ef135e86f5.zip chromium_src-63e56c83c4689dd0dfcef4b40e5fa8ef135e86f5.tar.gz chromium_src-63e56c83c4689dd0dfcef4b40e5fa8ef135e86f5.tar.bz2 | |
Add PPB_Alarms_Dev interface definition.
The C++ wrapper will be in a separate CL.
BUG=327197,233439
TEST=None
Review URL: https://codereview.chromium.org/103993006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240013 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/generators')
| -rwxr-xr-x | ppapi/generators/idl_c_header.py | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/ppapi/generators/idl_c_header.py b/ppapi/generators/idl_c_header.py index a3b8688..d3a1b32 100755 --- a/ppapi/generators/idl_c_header.py +++ b/ppapi/generators/idl_c_header.py @@ -145,12 +145,7 @@ def CheckTypedefs(filenode, releases): See http://crbug.com/233439 for details. """ cgen = CGen() - # TODO(teravest): Fix the following callback to pass PP_Var by pointer - # instead of by value. - node_whitelist = ['PP_Ext_Alarms_OnAlarm_Func_Dev_0_1'] for node in filenode.GetListOf('Typedef'): - if node.GetName() in node_whitelist: - continue build_list = node.GetUniqueReleases(releases) callnode = node.GetOneOf('Callspec') if callnode: @@ -162,7 +157,7 @@ def CheckTypedefs(filenode, releases): t = param.GetType(build_list[0]) while t.IsA('Typedef'): t = t.GetType(build_list[0]) - if t.IsA('Struct'): + if t.IsA('Struct') and t.GetProperty('passByValue'): raise Exception('%s is a struct in callback %s. ' 'See http://crbug.com/233439' % (t.GetName(), node.GetName())) |