summaryrefslogtreecommitdiffstats
path: root/ppapi/lib
diff options
context:
space:
mode:
authormseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-26 18:25:41 +0000
committermseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-26 18:25:41 +0000
commit866fdd9219e015f582095faf35129a3d9f26be8c (patch)
treefa14971f3b30742b05946ab0346c63736fac8168 /ppapi/lib
parentfa88fd91dd9ed3b57e7da4ad20670aedc7ca7099 (diff)
downloadchromium_src-866fdd9219e015f582095faf35129a3d9f26be8c.zip
chromium_src-866fdd9219e015f582095faf35129a3d9f26be8c.tar.gz
chromium_src-866fdd9219e015f582095faf35129a3d9f26be8c.tar.bz2
Windows Breakpad: Do Breakpad enablement checks in browser process only
Before this change, Chromium's various subprocesses run the same code as the browser process to check whether Breakpad is enabled. After this change, the browser process tells the subprocesses to enable Breakpad by setting an environment variable. This change fixes Breakpad enablement in nacl64.exe. The function GoogleUpdateSettings::GetCollectStatsConsent() did not work inside nacl64.exe because it checks the wrong registry key, because nacl64.exe is linked against google_chrome_distribution_dummy.cc which returns dummy registry key names. It would probably be cleaner to use a command line argument for this rather than an environment variable. Chromium uses a command line arg for this on Mac and Linux: "--enable-crash-reporter" (kEnableCrashReporter). However, the Mac/Linux approach doesn't work on Windows. "--enable-crash-reporter" is set in chrome_content_browser_client.cc (in chrome.dll on Windows), but this cannot call into breakpad_win.cc to check whether Breakpad got enabled because breakpad_win.cc is in chrome.exe. We reuse the env var that I added earlier for overriding the pipe name. I have only moved the code that computes pipe_name. The code that computes dump_type is still run in the subprocesses. BUG=111265 TEST=none Review URL: https://chromiumcodereview.appspot.com/9289032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123695 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/lib')
0 files changed, 0 insertions, 0 deletions