diff options
| author | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-22 21:35:00 +0000 |
|---|---|---|
| committer | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-22 21:35:00 +0000 |
| commit | 2b2068137e9e7faad29e60db6bd2fe2e8b44636e (patch) | |
| tree | f83177a627a9c36d0e1af185abd2ae761bedf50b /ppapi/native_client | |
| parent | 4abf36980992258df4bdb28c9c87629b41341736 (diff) | |
| download | chromium_src-2b2068137e9e7faad29e60db6bd2fe2e8b44636e.zip chromium_src-2b2068137e9e7faad29e60db6bd2fe2e8b44636e.tar.gz chromium_src-2b2068137e9e7faad29e60db6bd2fe2e8b44636e.tar.bz2 | |
[Coverity] Fix uninitialized member, pass-by-val.
CID=104035,104037
TBR=sehr@google.com
R=jhawkins@chromium.org
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10408051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138366 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/native_client')
| -rw-r--r-- | ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc | 20 | ||||
| -rw-r--r-- | ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h | 2 |
2 files changed, 12 insertions, 10 deletions
diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc index 84960b7..58db5d2 100644 --- a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc +++ b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc @@ -14,6 +14,7 @@ namespace plugin { PnaclTranslateThread::PnaclTranslateThread() : subprocesses_should_die_(false), manifest_(NULL), + ld_manifest_(NULL), obj_file_(NULL), nexe_file_(NULL), pexe_wrapper_(NULL), @@ -23,15 +24,16 @@ PnaclTranslateThread::PnaclTranslateThread() : subprocesses_should_die_(false), NaClXMutexCtor(&subprocess_mu_); } -void PnaclTranslateThread::RunTranslate(pp::CompletionCallback finish_callback, - const Manifest* manifest, - const Manifest* ld_manifest, - LocalTempFile* obj_file, - LocalTempFile* nexe_file, - nacl::DescWrapper* pexe_wrapper, - ErrorInfo* error_info, - PnaclResources* resources, - Plugin* plugin) { +void PnaclTranslateThread::RunTranslate( + const pp::CompletionCallback& finish_callback, + const Manifest* manifest, + const Manifest* ld_manifest, + LocalTempFile* obj_file, + LocalTempFile* nexe_file, + nacl::DescWrapper* pexe_wrapper, + ErrorInfo* error_info, + PnaclResources* resources, + Plugin* plugin) { PLUGIN_PRINTF(("PnaclTranslateThread::RunTranslate)\n")); manifest_ = manifest; ld_manifest_ = ld_manifest; diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h index 0ab5a42..bbd5792 100644 --- a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h +++ b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h @@ -33,7 +33,7 @@ class PnaclTranslateThread { virtual ~PnaclTranslateThread(); // TODO(jvoung/dschuff): handle surfaway issues when coordinator/plugin // goes away. This data may have to be refcounted not touched in that case. - void RunTranslate(pp::CompletionCallback finish_callback, + void RunTranslate(const pp::CompletionCallback& finish_callback, const Manifest* manifest, const Manifest* ld_manifest, LocalTempFile* obj_file, |