diff options
| author | mseaborn <mseaborn@chromium.org> | 2015-07-21 09:37:57 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-21 16:39:16 +0000 |
| commit | 770b328e9f6812f4695e92963e0246ffd4f701a4 (patch) | |
| tree | 4bc478f8f86ff060b9ce1b9c66e238647bc87710 /ppapi/ppapi_proxy.gypi | |
| parent | 1595fa25f05bb1f2bcbb73aefeceeb6329db299c (diff) | |
| download | chromium_src-770b328e9f6812f4695e92963e0246ffd4f701a4.zip chromium_src-770b328e9f6812f4695e92963e0246ffd4f701a4.tar.gz chromium_src-770b328e9f6812f4695e92963e0246ffd4f701a4.tar.bz2 | |
Reland of NaCl cleanup: Split out irt_interfaces.cc from irt_ppapi.cc (patchset #1 id:1 of https://codereview.chromium.org/1249473003/)
Reason for reland:
The size increase was caused by a Skia DEPS roll (https://codereview.chromium.org/1245793002/), not by this change.
Original issue's description:
> Revert of NaCl cleanup: Split out irt_interfaces.cc from irt_ppapi.cc (patchset #1 id:1 of https://codereview.chromium.org/1244533006/)
>
> Reason for revert:
> Regressed Linux sizes - 4.5% is a bit of a hit to take to bump sizes. If you're absolutely sure this is acceptable, update sizes as well.
>
> Original issue's description:
> > NaCl cleanup: Split out irt_interfaces.cc from irt_ppapi.cc
> >
> > The intention here is that irt_interfaces.{cc,h} should list the NaCl
> > IRT interfaces that we implement in Chromium but that other files
> > (like irt_ppapi.cc) should implement them. This matches how the files
> > are organised in native_client/src/untrusted/irt/.
> >
> > This is in preparation for copying the PNaCl translator IRT interfaces
> > to the Chromium side. That will add a couple more interfaces to
> > irt_interfaces.cc (rather than to irt_ppapi.cc).
> >
> > BUG=302078
> > TEST=NaCl tests in browser_tests
> >
> > Committed: https://crrev.com/5e662010c1f7881970de6de19bcbd50f2726ea00
> > Cr-Commit-Position: refs/heads/master@{#339508}
>
> TBR=jvoung@chromium.org,bbudge@chromium.org,mseaborn@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=302078
>
> Committed: https://crrev.com/db9f0a6b277a39d2f2b70d99e17801a18a6d79a6
> Cr-Commit-Position: refs/heads/master@{#339559}
BUG=302078
TBR=jvoung@chromium.org
Review URL: https://codereview.chromium.org/1245893002
Cr-Commit-Position: refs/heads/master@{#339666}
Diffstat (limited to 'ppapi/ppapi_proxy.gypi')
| -rw-r--r-- | ppapi/ppapi_proxy.gypi | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/ppapi/ppapi_proxy.gypi b/ppapi/ppapi_proxy.gypi index d099e0a..bfb3b5c 100644 --- a/ppapi/ppapi_proxy.gypi +++ b/ppapi/ppapi_proxy.gypi @@ -253,6 +253,8 @@ 'target_conditions': [ ['>(nacl_untrusted_build)==1', { 'sources': [ + 'nacl_irt/irt_interfaces.cc', + 'nacl_irt/irt_interfaces.h', 'nacl_irt/irt_ppapi.cc', 'nacl_irt/irt_ppapi.h', 'nacl_irt/irt_start.cc', |