diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-24 05:32:04 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-24 05:32:04 +0000 |
commit | a085aed793ce5577c7a0fca65e68447dd6d6f5ef (patch) | |
tree | a0799313b93fe269db084e68b229dddfcc9b5614 /ppapi/ppapi_shared.gypi | |
parent | f2202083f44fb378bc03e784c6a02e863e686b40 (diff) | |
download | chromium_src-a085aed793ce5577c7a0fca65e68447dd6d6f5ef.zip chromium_src-a085aed793ce5577c7a0fca65e68447dd6d6f5ef.tar.gz chromium_src-a085aed793ce5577c7a0fca65e68447dd6d6f5ef.tar.bz2 |
Convert the PPB_Flash interface to use the thunk system.
This was a bit tricky since some of the functions had no instance context, so I added global functions on the PpapiGlobals interface for them. It would be nice to add a PP_Instance argument and fix this in the future.
I did a new style of doing the thunking. The "function APIs" haven't really worked out since it's almost always easier to add the functions directly on the instance one. Since this is a larger and more separable chunk, I just added a getter on the instance API for the flash API and thunk through that. I'd like to convert the remaining ~3 function APIs to either call directly on the instance or use this method, but that's not addressed by this patch.
I moved the flash command line switch to plugin_switches so this could be hooked up properly. It allowed me to delete the delegate API for this.
I combined the flash fullscreen functions into the new Flash API which removed a bit of code.
Review URL: https://chromiumcodereview.appspot.com/10091003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133636 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/ppapi_shared.gypi')
-rw-r--r-- | ppapi/ppapi_shared.gypi | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/ppapi/ppapi_shared.gypi b/ppapi/ppapi_shared.gypi index ce8bc03..51f2383 100644 --- a/ppapi/ppapi_shared.gypi +++ b/ppapi/ppapi_shared.gypi @@ -171,8 +171,6 @@ 'thunk/ppb_device_ref_thunk.cc', 'thunk/ppb_directory_reader_api.h', 'thunk/ppb_directory_reader_thunk.cc', - 'thunk/ppb_input_event_api.h', - 'thunk/ppb_input_event_thunk.cc', 'thunk/ppb_file_chooser_api.h', 'thunk/ppb_file_chooser_thunk.cc', 'thunk/ppb_file_io_api.h', @@ -183,6 +181,7 @@ 'thunk/ppb_file_system_api.h', 'thunk/ppb_file_system_thunk.cc', 'thunk/ppb_find_thunk.cc', + 'thunk/ppb_flash_api.h', 'thunk/ppb_flash_clipboard_api.h', 'thunk/ppb_flash_clipboard_thunk.cc', 'thunk/ppb_flash_fullscreen_thunk.cc', @@ -190,6 +189,7 @@ 'thunk/ppb_flash_menu_thunk.cc', 'thunk/ppb_flash_message_loop_api.h', 'thunk/ppb_flash_message_loop_thunk.cc', + 'thunk/ppb_flash_thunk.cc', 'thunk/ppb_fullscreen_thunk.cc', 'thunk/ppb_gamepad_thunk.cc', 'thunk/ppb_gles_chromium_texture_mapping_thunk.cc', @@ -203,6 +203,8 @@ 'thunk/ppb_image_data_api.h', 'thunk/ppb_image_data_thunk.cc', 'thunk/ppb_image_data_trusted_thunk.cc', + 'thunk/ppb_input_event_api.h', + 'thunk/ppb_input_event_thunk.cc', 'thunk/ppb_instance_api.h', 'thunk/ppb_instance_thunk.cc', 'thunk/ppb_layer_compositor_api.h', |