diff options
author | raymes@chromium.org <raymes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-13 20:27:39 +0000 |
---|---|---|
committer | raymes@chromium.org <raymes@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-13 20:27:39 +0000 |
commit | 20a2046d5414402df68bf05eab4b57684b9a344f (patch) | |
tree | ac069889b8aab107c40a0d32e4397d55df1ae5d6 /ppapi/proxy/ppb_flash_proxy.cc | |
parent | 9b65eda8b1d6b247854cd808ec78d71241cda6b8 (diff) | |
download | chromium_src-20a2046d5414402df68bf05eab4b57684b9a344f.zip chromium_src-20a2046d5414402df68bf05eab4b57684b9a344f.tar.gz chromium_src-20a2046d5414402df68bf05eab4b57684b9a344f.tar.bz2 |
Fix code in breakpad_win.cc which handles crash data entries for ppapi plugins.
Previously the code was broken for ppapi plugins. In particular, the URL and
plugin path entries were never added to the crash data for ppapi (both of these
fields wouldn't exist in any prior crashes).
The code for setting up this data structure is pretty error prone and
this problem only manifested itself inside GoogleUpdate (omaha). I think the code
here should be rewritten but this should be done as part of a subsequent CL.
This also re-enables URLs in ppapi crash reports on windows.
BUG=135480
TEST=Made sure ppapi crashes get uploaded when the url is included.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10704179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146643 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/proxy/ppb_flash_proxy.cc')
-rw-r--r-- | ppapi/proxy/ppb_flash_proxy.cc | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/ppapi/proxy/ppb_flash_proxy.cc b/ppapi/proxy/ppb_flash_proxy.cc index df50196..227fda1 100644 --- a/ppapi/proxy/ppb_flash_proxy.cc +++ b/ppapi/proxy/ppb_flash_proxy.cc @@ -313,13 +313,6 @@ PP_Bool PPB_Flash_Proxy::SetCrashData(PP_Instance instance, PP_Var value) { switch (key) { case PP_FLASHCRASHKEY_URL: -#if defined(OS_WIN) - // TODO(raymes): This may be breaking crash reporting on Windows, see: - // See https://code.google.com/p/chromium/issues/detail?id=135480. - // Disable temporarily. - return PP_FALSE; -#endif - StringVar *url_string_var(StringVar::FromPPVar(value)); if (!url_string_var) return PP_FALSE; |