diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-03 18:05:43 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-03 18:05:43 +0000 |
| commit | 59d517948142f2239a9a993400fb5763be8ca102 (patch) | |
| tree | a0bb4ab353b0da9115e6744e607716fd7d103caa /ppapi/proxy/ppb_flash_proxy.cc | |
| parent | d1a59e4e845a01d7d7b80ef184b672752a9eae4d (diff) | |
| download | chromium_src-59d517948142f2239a9a993400fb5763be8ca102.zip chromium_src-59d517948142f2239a9a993400fb5763be8ca102.tar.gz chromium_src-59d517948142f2239a9a993400fb5763be8ca102.tar.bz2 | |
Keep a module reference during all Pepper message handling.
This prevents crashes in the case that a message causes the plugin to be
deleted.
BUG=153509
Review URL: https://codereview.chromium.org/11046010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159925 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/proxy/ppb_flash_proxy.cc')
| -rw-r--r-- | ppapi/proxy/ppb_flash_proxy.cc | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/ppapi/proxy/ppb_flash_proxy.cc b/ppapi/proxy/ppb_flash_proxy.cc index c45318c..9a7ace3 100644 --- a/ppapi/proxy/ppb_flash_proxy.cc +++ b/ppapi/proxy/ppb_flash_proxy.cc @@ -91,11 +91,6 @@ bool PPB_Flash_Proxy::OnMessageReceived(const IPC::Message& msg) { if (!dispatcher()->permissions().HasPermission(PERMISSION_FLASH)) return false; - // Prevent the dispatcher from going away during a call to Navigate. - // This must happen OUTSIDE of OnMsgNavigate since the handling code use - // the dispatcher upon return of the function (sending the reply message). - ScopedModuleReference death_grip(dispatcher()); - bool handled = true; IPC_BEGIN_MESSAGE_MAP(PPB_Flash_Proxy, msg) IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBFlash_SetInstanceAlwaysOnTop, |