summaryrefslogtreecommitdiffstats
path: root/ppapi/proxy/ppb_graphics_3d_proxy.h
diff options
context:
space:
mode:
authorbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-09-12 20:07:29 +0000
committerbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-09-12 20:07:29 +0000
commit62cccdac4221f25d83c84da8da70e7c540d4af35 (patch)
tree227fb39351ee5df0d6ac143f31527270b0c493d2 /ppapi/proxy/ppb_graphics_3d_proxy.h
parentcc89cd9a46629ca8230aae41f8ad2855c8b30264 (diff)
downloadchromium_src-62cccdac4221f25d83c84da8da70e7c540d4af35.zip
chromium_src-62cccdac4221f25d83c84da8da70e7c540d4af35.tar.gz
chromium_src-62cccdac4221f25d83c84da8da70e7c540d4af35.tar.bz2
This patch tries to remove most of the manual registration for Pepper interfaces, and replaces it with a list of macros. When files want to know which Pepper interface names and structs there are, they define what they want to do with the macros, and then include the relevant files for the classes of interfaces they want (stable, private, dev).
This does not convert all the dev interfaces. I just did a few to keep the patch smaller. So there is still a lot of manual registration. This fixes the previous design problem where we assumed one *_Proxy object == one interface. We have been hacking around this lately with duplicate GetInfo calls, but this doesn't work for PPP interfaces. Now, a _Proxy object is just there to help keep things organized. One proxy can handle zero, one, or many interfaces, and this mapping is controlled by just one line in the interfaces file. So for example, to add a new function to a new version of an interface with backward compatibility, you would add that function to the _api.h file, and write a thunk for the new interface. Then you only need to add one line to the interfaces_ppb_public_stable.h file and that will be hooked up with the proxy and the implementation. This removes some _proxy objects/files that were used only to declare that the interfaces existed, since they're no longer necessary. I folded Console into the Instance API which removed a bunch of code. I removed FileChooser 0.4. I think everybody has converted to the new one, and I think parts of it weren't even hooked up properly anymore. Review URL: http://codereview.chromium.org/7740038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100748 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/proxy/ppb_graphics_3d_proxy.h')
-rw-r--r--ppapi/proxy/ppb_graphics_3d_proxy.h10
1 files changed, 3 insertions, 7 deletions
diff --git a/ppapi/proxy/ppb_graphics_3d_proxy.h b/ppapi/proxy/ppb_graphics_3d_proxy.h
index 4fd97a2..ef2b70b 100644
--- a/ppapi/proxy/ppb_graphics_3d_proxy.h
+++ b/ppapi/proxy/ppb_graphics_3d_proxy.h
@@ -63,22 +63,18 @@ class Graphics3D : public Resource, public Graphics3DImpl {
class PPB_Graphics3D_Proxy : public InterfaceProxy {
public:
- PPB_Graphics3D_Proxy(Dispatcher* dispatcher, const void* target_interface);
+ PPB_Graphics3D_Proxy(Dispatcher* dispatcher);
virtual ~PPB_Graphics3D_Proxy();
- static const Info* GetInfo();
-
static PP_Resource CreateProxyResource(PP_Instance instance,
PP_Resource share_context,
const int32_t* attrib_list);
- const PPB_Graphics3D* ppb_graphics_3d_target() const {
- return static_cast<const PPB_Graphics3D*>(target_interface());
- }
-
// InterfaceProxy implementation.
virtual bool OnMessageReceived(const IPC::Message& msg);
+ static const InterfaceID kInterfaceID = INTERFACE_ID_PPB_GRAPHICS_3D;
+
private:
void OnMsgCreate(PP_Instance instance,
const std::vector<int32_t>& attribs,