diff options
author | polina@google.com <polina@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-27 04:24:30 +0000 |
---|---|---|
committer | polina@google.com <polina@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-27 04:24:30 +0000 |
commit | 06e0a34ae11c97e35ae67f6a006dc4a45cda58af (patch) | |
tree | a6766fa80232f512030a7c68726c5c6137e5a52d /ppapi/proxy/ppp_instance_proxy_unittest.cc | |
parent | 325e9d2d3e52b4402c82c9b3c0c2163ef0f09020 (diff) | |
download | chromium_src-06e0a34ae11c97e35ae67f6a006dc4a45cda58af.zip chromium_src-06e0a34ae11c97e35ae67f6a006dc4a45cda58af.tar.gz chromium_src-06e0a34ae11c97e35ae67f6a006dc4a45cda58af.tar.bz2 |
Add PPB_Fullscreen_Dev;0.5. Keep 0.4 for backwards compatiblity and point it
to PPB_FlashFullscreen. The new implementation is based on
http://codereview.chromium.org/7714017/ with some bug fixes.
Update header comments.
Main API differences between the old and the new implementation:
- transition from fullscreen is now asynchronous and ends at DidChangeView
just like transition to fullscreen; graphics devices cannot be bound during
the transition.
- when switching to/from fullscreen 3D resources no longer need to be
re-created.
- transitions to fullscreen are only possible when processing user user gestures.
- transition to fullscreen results in 2 DidChangeViews, one for moving the
plugin to the middle of the window and one for stretching the window and
placing the plugin in the middle of the screen.
- the size of the plugin is not changed when going to/from fullscreen.
Testing:
- Mapped ppapi_tests:test_fullscreen to ppapi_tests:test_flash_fullscreen.
- Updated test_fullscreen to work with the new implementation. To be testable
automatically this needs enhancements to the testing infrastructure
for generating user gestures. For now marked the test as DISABLED.
- Disabled NaCl's ppapi_ppb_fullscreen_browser_test for the same reasons
as above.
- To re-enable both tests, we will first need to add user gesture capabilites
to PPB_Testing.
- Build 0.4 ppapi_test:test_fullscreen and ran this out of process and in
process with the newly build revision of chrome to verify backwards
compatability.
- In a separate CL, will update NaCl's ppapi_ppb_fullscreen_browser_test to work
with the new implementation, for now only manually.
BUG=41780
TEST=see above
Review URL: http://codereview.chromium.org/7826017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102888 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/proxy/ppp_instance_proxy_unittest.cc')
-rw-r--r-- | ppapi/proxy/ppp_instance_proxy_unittest.cc | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/ppapi/proxy/ppp_instance_proxy_unittest.cc b/ppapi/proxy/ppp_instance_proxy_unittest.cc index f28215a..96ac24c 100644 --- a/ppapi/proxy/ppp_instance_proxy_unittest.cc +++ b/ppapi/proxy/ppp_instance_proxy_unittest.cc @@ -4,6 +4,7 @@ #include "base/synchronization/waitable_event.h" #include "ipc/ipc_message_utils.h" +#include "ppapi/c/dev/ppb_fullscreen_dev.h" #include "ppapi/c/pp_var.h" #include "ppapi/c/ppb_core.h" #include "ppapi/c/ppb_url_loader.h" @@ -89,11 +90,12 @@ PPP_Instance_1_0 ppp_instance_1_0 = { &HandleDocumentLoad }; -// PPP_Instance_Proxy::DidChangeView relies on PPB_Fullscreen being +// PPP_Instance_Proxy::DidChangeView relies on PPB_(Flash)Fullscreen being // available with a valid implementation of IsFullScreen, so we mock it. PP_Bool IsFullscreen(PP_Instance instance) { return PP_FALSE; } +PPB_Fullscreen_Dev ppb_fullscreen = { &IsFullscreen }; PPB_FlashFullscreen ppb_flash_fullscreen = { &IsFullscreen }; } // namespace @@ -109,6 +111,8 @@ TEST_F(PPP_Instance_ProxyTest, PPPInstance1_0) { plugin().RegisterTestInterface(PPP_INSTANCE_INTERFACE_1_0, &ppp_instance_1_0); host().RegisterTestInterface(PPB_FLASHFULLSCREEN_INTERFACE, &ppb_flash_fullscreen); + host().RegisterTestInterface(PPB_FULLSCREEN_DEV_INTERFACE, + &ppb_fullscreen); // Grab the host-side proxy for the 1.0 interface. const PPP_Instance_1_0* ppp_instance = static_cast<const PPP_Instance_1_0*>( @@ -176,4 +180,3 @@ TEST_F(PPP_Instance_ProxyTest, PPPInstance1_0) { } // namespace proxy } // namespace ppapi - |