diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-22 17:48:48 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-22 17:48:48 +0000 |
| commit | 2b53078fea6c2c2aa00502850824d8269c796dce (patch) | |
| tree | 86766317b3c566ca1c18249f4f5dccee04f89b37 /ppapi/proxy | |
| parent | baa0d5ec17cd8d725c88128e1f2f0b867c2a8170 (diff) | |
| download | chromium_src-2b53078fea6c2c2aa00502850824d8269c796dce.zip chromium_src-2b53078fea6c2c2aa00502850824d8269c796dce.tar.gz chromium_src-2b53078fea6c2c2aa00502850824d8269c796dce.tar.bz2 | |
Fix bug caught by clang's -Wlogical-not-parentheses
../../ppapi/proxy/ppb_image_data_proxy.cc:153:9: error: logical not is only applied to the left hand side of this comparison [-Werror,-Wlogical-not-parentheses]
if (!images_[i].image->type() == type)
^ ~~
../../ppapi/proxy/ppb_image_data_proxy.cc:153:9: note: add parentheses after the '!' to evaluate the comparison first
if (!images_[i].image->type() == type)
^
( )
../../ppapi/proxy/ppb_image_data_proxy.cc:153:9: note: add parentheses around left hand side expression to silence this warning
if (!images_[i].image->type() == type)
^
( )
1 error generated.
(Since PPB_ImageData_Shared::ImageDataType currently has only two values, this is no behavior change.)
BUG=262248
R=yzshen@chromium.org
Review URL: https://codereview.chromium.org/19954006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212908 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/proxy')
| -rw-r--r-- | ppapi/proxy/ppb_image_data_proxy.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ppapi/proxy/ppb_image_data_proxy.cc b/ppapi/proxy/ppb_image_data_proxy.cc index ab61c7b..0ed3c24 100644 --- a/ppapi/proxy/ppb_image_data_proxy.cc +++ b/ppapi/proxy/ppb_image_data_proxy.cc @@ -150,7 +150,7 @@ scoped_refptr<ImageData> ImageDataInstanceCache::Get( for (int i = 0; i < kCacheSize; i++) { if (!images_[i].usable) continue; - if (!images_[i].image->type() == type) + if (images_[i].image->type() != type) continue; const PP_ImageDataDesc& desc = images_[i].image->desc(); if (desc.format == format && |