diff options
author | rtenneti@chromium.org <rtenneti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-06 23:53:21 +0000 |
---|---|---|
committer | rtenneti@chromium.org <rtenneti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-06 23:53:21 +0000 |
commit | f26d7fa665143e0bf1c173e093f9eadce0a10e97 (patch) | |
tree | 37c5af95ab97e4ede3413b06dd62497ae8ac9245 /ppapi/shared_impl/ppapi_preferences.h | |
parent | a74cd952d16628d25641bfb1ae1aaa6f883a117a (diff) | |
download | chromium_src-f26d7fa665143e0bf1c173e093f9eadce0a10e97.zip chromium_src-f26d7fa665143e0bf1c173e093f9eadce0a10e97.tar.gz chromium_src-f26d7fa665143e0bf1c173e093f9eadce0a10e97.tar.bz2 |
Revert of 112134 of Revert 112130 - Close idle connections / SPDY sessions when needed.
Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit.
Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket.
Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is probably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan).
BUG=62364,92244, 105839
TEST=none
Review URL: http://codereview.chromium.org/8340012
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/8745007
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/8803019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113300 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/shared_impl/ppapi_preferences.h')
0 files changed, 0 insertions, 0 deletions