diff options
| author | dmichael@chromium.org <dmichael@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-23 14:27:42 +0000 |
|---|---|---|
| committer | dmichael@chromium.org <dmichael@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-23 14:27:42 +0000 |
| commit | aed965375dec978e7feb8722b1b94250a2a6e039 (patch) | |
| tree | 9f8ccdf7a3902fa1db54e0c036f7cb9ca96775fb /ppapi/shared_impl/ppb_audio_config_shared.cc | |
| parent | 94bd0a2e94c1f07ccc0236a95e57a2e16b94038a (diff) | |
| download | chromium_src-aed965375dec978e7feb8722b1b94250a2a6e039.zip chromium_src-aed965375dec978e7feb8722b1b94250a2a6e039.tar.gz chromium_src-aed965375dec978e7feb8722b1b94250a2a6e039.tar.bz2 | |
PPAPI: Make blocking completion callbacks work.
This also makes scoped_refptr<TrackedCallback> the "new" way to pass completion callbacks in an API. This allows the Enter object to handle checking for blocking callbacks on the main thread to report error, and blocking if on the background thread. This way, interfaces don't have to write any special cases for blocking callbacks.
When built with enable_pepper_threading=1 locally, URLLoader tests all pass for blocking completion callbacks. I haven't updated all tests yet.
BUG=92909
TEST=
Review URL: https://chromiumcodereview.appspot.com/10081020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143806 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/shared_impl/ppb_audio_config_shared.cc')
| -rw-r--r-- | ppapi/shared_impl/ppb_audio_config_shared.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ppapi/shared_impl/ppb_audio_config_shared.cc b/ppapi/shared_impl/ppb_audio_config_shared.cc index 6803c3c..1252de7 100644 --- a/ppapi/shared_impl/ppb_audio_config_shared.cc +++ b/ppapi/shared_impl/ppb_audio_config_shared.cc @@ -50,7 +50,7 @@ uint32_t PPB_AudioConfig_Shared::RecommendSampleFrameCount_1_1( uint32_t sample_frame_count) { // Version 1.1: Query the back-end hardware for sample rate and buffer size, // and recommend a best fit based on request. - thunk::EnterInstance enter(instance); + thunk::EnterInstanceNoLock enter(instance); if (enter.failed()) return 0; @@ -92,7 +92,7 @@ uint32_t PPB_AudioConfig_Shared::RecommendSampleFrameCount_1_1( // static PP_AudioSampleRate PPB_AudioConfig_Shared::RecommendSampleRate( PP_Instance instance) { - thunk::EnterInstance enter(instance); + thunk::EnterInstanceNoLock enter(instance); if (enter.failed()) return PP_AUDIOSAMPLERATE_NONE; PP_AudioSampleRate hardware_sample_rate = static_cast<PP_AudioSampleRate>( |