diff options
author | dmichael@chromium.org <dmichael@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-23 14:27:42 +0000 |
---|---|---|
committer | dmichael@chromium.org <dmichael@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-23 14:27:42 +0000 |
commit | aed965375dec978e7feb8722b1b94250a2a6e039 (patch) | |
tree | 9f8ccdf7a3902fa1db54e0c036f7cb9ca96775fb /ppapi/shared_impl/ppb_video_capture_shared.h | |
parent | 94bd0a2e94c1f07ccc0236a95e57a2e16b94038a (diff) | |
download | chromium_src-aed965375dec978e7feb8722b1b94250a2a6e039.zip chromium_src-aed965375dec978e7feb8722b1b94250a2a6e039.tar.gz chromium_src-aed965375dec978e7feb8722b1b94250a2a6e039.tar.bz2 |
PPAPI: Make blocking completion callbacks work.
This also makes scoped_refptr<TrackedCallback> the "new" way to pass completion callbacks in an API. This allows the Enter object to handle checking for blocking callbacks on the main thread to report error, and blocking if on the background thread. This way, interfaces don't have to write any special cases for blocking callbacks.
When built with enable_pepper_threading=1 locally, URLLoader tests all pass for blocking completion callbacks. I haven't updated all tests yet.
BUG=92909
TEST=
Review URL: https://chromiumcodereview.appspot.com/10081020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143806 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/shared_impl/ppb_video_capture_shared.h')
-rw-r--r-- | ppapi/shared_impl/ppb_video_capture_shared.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/ppapi/shared_impl/ppb_video_capture_shared.h b/ppapi/shared_impl/ppb_video_capture_shared.h index b5c3385..80b29fe 100644 --- a/ppapi/shared_impl/ppb_video_capture_shared.h +++ b/ppapi/shared_impl/ppb_video_capture_shared.h @@ -29,11 +29,11 @@ class PPAPI_SHARED_EXPORT PPB_VideoCapture_Shared // PPB_VideoCapture_API implementation. virtual int32_t EnumerateDevices( PP_Resource* devices, - const PP_CompletionCallback& callback) OVERRIDE; + scoped_refptr<TrackedCallback> callback) OVERRIDE; virtual int32_t Open(const std::string& device_id, const PP_VideoCaptureDeviceInfo_Dev& requested_info, uint32_t buffer_count, - const PP_CompletionCallback& callback) OVERRIDE; + scoped_refptr<TrackedCallback> callback) OVERRIDE; virtual int32_t StartCapture() OVERRIDE; virtual int32_t ReuseBuffer(uint32_t buffer) OVERRIDE; virtual int32_t StopCapture() OVERRIDE; @@ -58,12 +58,12 @@ class PPAPI_SHARED_EXPORT PPB_VideoCapture_Shared // work. virtual int32_t InternalEnumerateDevices( PP_Resource* devices, - const PP_CompletionCallback& callback) = 0; + scoped_refptr<TrackedCallback> callback) = 0; virtual int32_t InternalOpen( const std::string& device_id, const PP_VideoCaptureDeviceInfo_Dev& requested_info, uint32_t buffer_count, - const PP_CompletionCallback& callback) = 0; + scoped_refptr<TrackedCallback> callback) = 0; virtual int32_t InternalStartCapture() = 0; virtual int32_t InternalReuseBuffer(uint32_t buffer) = 0; virtual int32_t InternalStopCapture() = 0; |