diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-22 22:15:58 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-22 22:15:58 +0000 |
| commit | 28cfaed056451113a72ce00603848f4a6dd616bb (patch) | |
| tree | c5de865eb7de9ea487b9af79dac9c9d363ba2876 /ppapi/shared_impl/url_util_impl.cc | |
| parent | bacf470d2cd46c0d3b145675e471ab9c6976cee8 (diff) | |
| download | chromium_src-28cfaed056451113a72ce00603848f4a6dd616bb.zip chromium_src-28cfaed056451113a72ce00603848f4a6dd616bb.tar.gz chromium_src-28cfaed056451113a72ce00603848f4a6dd616bb.tar.bz2 | |
Don't use a scoped_refptr for StringVar::FromPPVar
This was leftover from a previous design where I thought it would be
necessary. It turns out it just made the code ugly and did unnecessary
refcounting.
Review URL: http://codereview.chromium.org/7621054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97751 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/shared_impl/url_util_impl.cc')
| -rw-r--r-- | ppapi/shared_impl/url_util_impl.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/ppapi/shared_impl/url_util_impl.cc b/ppapi/shared_impl/url_util_impl.cc index 66a6185..ddad401 100644 --- a/ppapi/shared_impl/url_util_impl.cc +++ b/ppapi/shared_impl/url_util_impl.cc @@ -44,7 +44,7 @@ void ConvertComponents(const url_parse::Parsed& input, PP_Var URLUtilImpl::Canonicalize(PP_Module pp_module, PP_Var url, PP_URLComponents_Dev* components) { - scoped_refptr<StringVar> url_string(StringVar::FromPPVar(url)); + StringVar* url_string = StringVar::FromPPVar(url); if (!url_string) return PP_MakeNull(); return GenerateURLReturn(pp_module, GURL(url_string->value()), components); @@ -55,8 +55,8 @@ PP_Var URLUtilImpl::ResolveRelativeToURL(PP_Module pp_module, PP_Var base_url, PP_Var relative, PP_URLComponents_Dev* components) { - scoped_refptr<StringVar> base_url_string(StringVar::FromPPVar(base_url)); - scoped_refptr<StringVar> relative_string(StringVar::FromPPVar(relative)); + StringVar* base_url_string = StringVar::FromPPVar(base_url); + StringVar* relative_string = StringVar::FromPPVar(relative); if (!base_url_string || !relative_string) return PP_MakeNull(); @@ -70,8 +70,8 @@ PP_Var URLUtilImpl::ResolveRelativeToURL(PP_Module pp_module, // static PP_Bool URLUtilImpl::IsSameSecurityOrigin(PP_Var url_a, PP_Var url_b) { - scoped_refptr<StringVar> url_a_string(StringVar::FromPPVar(url_a)); - scoped_refptr<StringVar> url_b_string(StringVar::FromPPVar(url_b)); + StringVar* url_a_string = StringVar::FromPPVar(url_a); + StringVar* url_b_string = StringVar::FromPPVar(url_b); if (!url_a_string || !url_b_string) return PP_FALSE; |