Replace the use of an int32* with an explicit profile for decoder configuration.

Replaces the error-prone, overly-general, error-containing, and brittle
manually-terminated array-of-ints holding name/value pairs (except for names
that don't take values) with a simple profile parameter (specifying only information we
actually use today).

BUG=none
TEST=trybots, ovdatest, gles2

Review URL: http://codereview.chromium.org/7779001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99111 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 0 insertions, 20 deletions

diff --git a/ppapi/shared_impl/video_decoder_impl.cc b/ppapi/shared_impl/video_decoder_impl.cc
index 00d971b..71921f92 100644
--- a/ppapi/shared_impl/video_decoder_impl.cc
+++ b/ppapi/shared_impl/video_decoder_impl.cc
@@ -89,19 +89,4 @@ void VideoDecoderImpl::FlushCommandBuffer() {
     gles2_impl_->Flush();
 }
 
-bool VideoDecoderImpl::CopyConfigsToVector(
-    const PP_VideoConfigElement* configs_to_copy,
-    std::vector<PP_VideoConfigElement>* out_configs) {
-  // TODO(fischman/vrk): This is still broken. We need to get rid of the silly
-  // PP_VideoConfigElement vector in favor of a struct (see TODO in
-  // ppb_video_decoder_dev.h).
-  const PP_VideoConfigElement* current = configs_to_copy;
-  while (current && *current != PP_VIDEOATTR_DICTIONARY_TERMINATOR) {
-    out_configs->push_back(*current);
-    out_configs->push_back(*(current + 1));
-    current += 2;
-  }
-  return true;
-}
-
 }  // namespace ppapi
diff --git a/ppapi/shared_impl/video_decoder_impl.h b/ppapi/shared_impl/video_decoder_impl.h
index b71f27d..1060740 100644
--- a/ppapi/shared_impl/video_decoder_impl.h
+++ b/ppapi/shared_impl/video_decoder_impl.h
@@ -39,11 +39,6 @@ class PPAPI_SHARED_EXPORT VideoDecoderImpl
   // PPB_VideoDecoder_API implementation.
   virtual void Destroy() OVERRIDE;
 
-  // Copy C-style config list into |out_configs| vector.
-  static bool CopyConfigsToVector(
-      const PP_VideoConfigElement* configs_to_copy,
-      std::vector<PP_VideoConfigElement>* out_configs);
-
  protected:
   bool SetFlushCallback(PP_CompletionCallback callback);
   bool SetResetCallback(PP_CompletionCallback callback);