diff options
| author | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-23 18:19:02 +0000 |
|---|---|---|
| committer | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-23 18:19:02 +0000 |
| commit | 2d6417168fa95e32ccc97b6fbaada980e5f816aa (patch) | |
| tree | 17901ab606955cb2e919f80a6b639c915d1ace7c /ppapi/shared_impl | |
| parent | 0f06b4b5bdc50c9880b1f1cc580ec8e6b2cd0541 (diff) | |
| download | chromium_src-2d6417168fa95e32ccc97b6fbaada980e5f816aa.zip chromium_src-2d6417168fa95e32ccc97b6fbaada980e5f816aa.tar.gz chromium_src-2d6417168fa95e32ccc97b6fbaada980e5f816aa.tar.bz2 | |
[Coverity] Fixed resource leak.
DeepCopy creates a ListValue*, which swap (correctly) doesn't free.
CID=103840
R=brettw,raymes
BUG=
TEST=
Review URL: http://codereview.chromium.org/10168015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133478 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/shared_impl')
| -rw-r--r-- | ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc b/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc index 35c9d0e..5bf74cb 100644 --- a/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc +++ b/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc @@ -15,7 +15,8 @@ PPB_X509Certificate_Fields::PPB_X509Certificate_Fields() {} PPB_X509Certificate_Fields::PPB_X509Certificate_Fields( const PPB_X509Certificate_Fields& fields) { - values_.Swap(fields.values_.DeepCopy()); + scoped_ptr<ListValue> new_values(fields.values_.DeepCopy()); + values_.Swap(new_values.get()); } void PPB_X509Certificate_Fields::SetField( |