diff options
| author | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-01 23:20:32 +0000 |
|---|---|---|
| committer | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-01 23:20:32 +0000 |
| commit | d71d5fc8821a0bb38dc2d14c94a84975ce9fafb0 (patch) | |
| tree | d49269c1a3ba70138ae481ee565f85b6edd60fff /ppapi/tests/test_host_resolver_private.cc | |
| parent | 84c384ee708f30c5b47e49f86337b7285a226f65 (diff) | |
| download | chromium_src-d71d5fc8821a0bb38dc2d14c94a84975ce9fafb0.zip chromium_src-d71d5fc8821a0bb38dc2d14c94a84975ce9fafb0.tar.gz chromium_src-d71d5fc8821a0bb38dc2d14c94a84975ce9fafb0.tar.bz2 | |
Fix OmniboxViewViews Tab handling on Win; handle Page[Up|Down].
Override SkipDefaultKeyEventProcessing for Tab key handling.
(called on Win before tab-to-focus accelerator handling)
Call SkipDefaultKeyEventProcessing explicitly on !OS_WIN || USE_AURA.
(retains CrOS behavior, which doesn't typically call SkipDefault...)
(Added a TODO to clean up this cross-platform behavior mismatch)
Handle VKEY_PRIOR and VKEY_NEXT (Page[Up|Down]) like OmniboxViewWin.
This meets expected behavior and fixes some interactive_ui_tests for WIP CL:
https://codereview.chromium.org/12330177/
Remove Textfield::SkipDefaultKeyEventProcessing NOTIMPLEMENTED().
(it pointlessly adds logging verbosity, just returning false is ok)
Remove Instant support TODO (it seems to work as expected).
BUG=134980,131660
TEST=Tab and Page[Up|Down] keys behave as expected in CrOS, Win-Aura, and non-Aura Win with --enable-views-textfield.
R=pkasting@chromium.org,sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12385011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185612 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/tests/test_host_resolver_private.cc')
0 files changed, 0 insertions, 0 deletions