diff options
author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-09 00:19:33 +0000 |
---|---|---|
committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-09 00:19:33 +0000 |
commit | c1371f576cde5075206434c94bd462397f6e6809 (patch) | |
tree | 10ba48876e42ae45d30d999aa948272b00738ac7 /ppapi/tests/testing_instance.h | |
parent | b3dc82b6fd757ca2314990afcad0c4650c43845e (diff) | |
download | chromium_src-c1371f576cde5075206434c94bd462397f6e6809.zip chromium_src-c1371f576cde5075206434c94bd462397f6e6809.tar.gz chromium_src-c1371f576cde5075206434c94bd462397f6e6809.tar.bz2 |
Revert 109114
Turned Mac valgrind bots red:
OutOfProcessPPAPITest.PostMessage_MessageEvent
OutOfProcessPPAPITest.PostMessage_ExtraParam
PPAPITest.PostMessage_NoHandler
OutOfProcessPPAPITest.PostMessage_SendInInit
Probably others
- Make it possible to enable/disable specific ppapi tests. Migrate PostMessage tests.
Most of these files were changed by a sed script, so it's not as bad as it looks.
The testcase attribute now can include a 'filter'. If it's omitted, everything works the same as before. This way we can migrate tests over bit-by-bit if we want to. We can also still run the tests manually the same way as before.
This only runs PostMessage testss the new way, and re-enables all oop PostMessage tests that pass on Windows. I can do the other tests in this CL if desired, but it might be easier to land in a few pieces.
BUG=102885,95557
TEST=N/A
Review URL: http://codereview.chromium.org/8477015
TBR=dmichael@chromium.org
Review URL: http://codereview.chromium.org/8497030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109142 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/tests/testing_instance.h')
-rw-r--r-- | ppapi/tests/testing_instance.h | 18 |
1 files changed, 2 insertions, 16 deletions
diff --git a/ppapi/tests/testing_instance.h b/ppapi/tests/testing_instance.h index 8f6b7b1..0c79923 100644 --- a/ppapi/tests/testing_instance.h +++ b/ppapi/tests/testing_instance.h @@ -87,18 +87,8 @@ pp::InstancePrivate { void ExecuteTests(int32_t unused); // Creates a new TestCase for the give test name, or NULL if there is no such - // test. Ownership is passed to the caller. The given string is split by '_'. - // The test case name is the first part. - TestCase* CaseForTestName(const std::string& name); - // Returns the filter (second part) of the given string. If there is no '_', - // returns the empty string, which means 'run all tests for this test case'. - // E.g.: - // http://testserver/test_case.html?testcase=PostMessage - // Otherwise, the part of the testcase after '_' is returned, and the test - // whose name matches that string (if any) will be run: - // http://testserver/test_case.html?testcase=PostMessage_SendingData - // Runs 'PostMessage_SendingData. - std::string FilterForTestName(const std::string& name); + // test. Ownership is passed to the caller. + TestCase* CaseForTestName(const char* name); // Appends a list of available tests to the console in the document. void LogAvailableTests(); @@ -119,10 +109,6 @@ pp::InstancePrivate { // Owning pointer to the current test case. Valid after Init has been called. TestCase* current_case_; - // A filter to use when running tests. This is passed to 'RunTests', which - // runs only tests whose name contains test_filter_ as a substring. - std::string test_filter_; - // The current step we're on starting at 0. This is incremented every time we // report progress via a cookie. See comment above the class. int progress_cookie_number_; |