diff options
author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-29 06:28:29 +0000 |
---|---|---|
committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-29 06:28:29 +0000 |
commit | c224933cbc7e2c12a65481d951dff15b2bfccf31 (patch) | |
tree | c03f0fc13ee09eb7226e396acd5f82483933f964 /ppapi/tests/testing_instance.h | |
parent | a3614899984ed5eff5b8a3afa3e7166a2282c528 (diff) | |
download | chromium_src-c224933cbc7e2c12a65481d951dff15b2bfccf31.zip chromium_src-c224933cbc7e2c12a65481d951dff15b2bfccf31.tar.gz chromium_src-c224933cbc7e2c12a65481d951dff15b2bfccf31.tar.bz2 |
Revert 124106, turns memory bots red across the bord (linux, cros).
Example stack:
Suppression (error hash=#C5EB54BF2F81B151#):
For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
<insert_a_suppression_name_here>
Memcheck:Leak
fun:_Znw*
fun:_ZN6webkit5ppapi12PluginObject21AllocateObjectWrapperEv
fun:_ZN6webkit5ppapi12_GLOBAL__N_121WrapperClass_AllocateEP4_NPPP7NPClass
fun:_NPN_CreateObject
fun:_ZN6WebKit11WebBindings12createObjectEP4_NPPP7NPClass
fun:_ZN6webkit5ppapi12PluginObject6CreateEPNS0_14PluginInstanceEPK20PPP_Class_DeprecatedPv
fun:_ZN6webkit5ppapi12_GLOBAL__N_122CreateObjectDeprecatedEiPK20PPP_Class_DeprecatedPv
fun:_ZN2pp10VarPrivateC1ERKNS_14InstanceHandleEPNS_10deprecated16ScriptableObjectE
fun:_ZN8TestCase13GetTestObjectEv
fun:_ZN15TestingInstance17GetInstanceObjectEv
fun:_ZN2pp12_GLOBAL__N_117GetInstanceObjectEi
fun:_ZN6webkit5ppapi14PluginInstance17GetInstanceObjectEv
fun:_ZN6webkit5ppapi13WebPluginImpl16scriptableObjectEv
fun:_ZN6WebKit22WebPluginContainerImpl16scriptableObjectEv
fun:_ZN7WebCore15PlatformSupport22pluginScriptableObjectEPNS_6WidgetE
fun:_ZN7WebCore16ScriptController29createScriptInstanceForWidgetEPNS_6WidgetE
fun:_ZN7WebCore17HTMLPlugInElement11getInstanceEv
fun:_ZN7WebCoreL19npObjectNamedGetterINS_18V8HTMLEmbedElementEEEN2v86HandleINS2_5ValueEEENS2_5LocalINS2_6StringEEERKNS2_12AccessorInfoE
fun:_ZN7WebCore18V8HTMLEmbedElement19namedPropertyGetterEN2v85LocalINS1_6StringEEERKNS1_12AccessorInfoE
fun:_ZN2v88internal8JSObject26GetPropertyWithInterceptorEPNS0_10JSReceiverEPNS0_6StringEP18PropertyAttributes
obj:*
}
- PPAPI: Really force-free NPObjects on Instance destruction.
(There still seems to be a memory leak with this patch; I may have to check our NPObject reference counting next.)
BUG=114023
TEST=
Review URL: http://codereview.chromium.org/9403039
TBR=dmichael@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9540004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124138 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/tests/testing_instance.h')
-rw-r--r-- | ppapi/tests/testing_instance.h | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/ppapi/tests/testing_instance.h b/ppapi/tests/testing_instance.h index f480e9d..7b05174 100644 --- a/ppapi/tests/testing_instance.h +++ b/ppapi/tests/testing_instance.h @@ -1,4 +1,4 @@ -// Copyright (c) 2012 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -89,11 +89,6 @@ pp::InstancePrivate { // Sets the given cookie in the current document. void SetCookie(const std::string& name, const std::string& value); - // Add a post-condition to the JavaScript on the test_case.html page. This - // JavaScript code will be run after the instance is shut down and must - // evaluate to |true| or the test will fail. - void AddPostCondition(const std::string& script); - private: void ExecuteTests(int32_t unused); @@ -111,10 +106,6 @@ pp::InstancePrivate { // Runs 'PostMessage_SendingData. std::string FilterForTestName(const std::string& name); - // Sends a test command to the page using PostMessage. - void SendTestCommand(const std::string& command); - void SendTestCommand(const std::string& command, const std::string& params); - // Appends a list of available tests to the console in the document. void LogAvailableTests(); |