PPAPI/NaCl: Make tests enforce dispatchEvent check

Bug 109775 was fixed by https://src.chromium.org/viewvc/chrome?view=rev&revision=233356

So now I can give the tests some teeth for NaCl to make sure we don't regress on issue 109775. I tested this locally with and without rev 233356 to make sure that the test would fail without that fix.

BUG=109775

Review URL: https://codereview.chromium.org/65793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234069 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 4 insertions, 12 deletions

diff --git a/ppapi/tests/test_case.html b/ppapi/tests/test_case.html
index 1552ae2..12053bc 100644
--- a/ppapi/tests/test_case.html
+++ b/ppapi/tests/test_case.html
@@ -297,14 +297,7 @@ onload = function() {
     // below.
     var original = obj.dispatchEvent;
     obj.dispatchEvent = function() {
-      // TODO(dmichael): NaCl triggers this; take out the special case for NaCl
-      //                 when crbug.com/109775 is fixed.
-      if (mode.indexOf("nacl") !== 0)
-        InternalError("Bad dispatchEvent called!");
-
-      // Pass it on anyways, we need the event to detect load progress and
-      // errors.
-      return original.apply(obj, arguments);
+      InternalError("Bad dispatchEvent called!");
     }
     container.appendChild(obj);
   }
@@ -314,10 +307,9 @@ onload = function() {
 // This part of the script does some nefarious things to make sure that it
 // doesn't affect the behavior of PostMessage (on which all the tests rely). In
 // particular, we replace document.createEvent, MessageEvent.initMessageEvent,
-// and the MessageEvent constructor. Previous versions of the PostMessage
-// implementation made use of these and would fail (http://crbug.com/82604).
-// The NaCl plugin uses dispatchEvent for progress events, hence we are careful
-// to make that still pass for NaCl (see above, and see crbug.com/109775).
+// and the MessageEvent constructor. Previously, the NaCl integration
+// implementation made use of these and would fail (http://crbug.com/82604
+// and http://crbug.com/109775).
 document.createEvent = function() {
   InternalError("Bad document.createEvent called!");
 }