diff options
| author | vrk@google.com <vrk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-19 16:29:07 +0000 |
|---|---|---|
| committer | vrk@google.com <vrk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-19 16:29:07 +0000 |
| commit | 6ceb1207c32f4ecdd9d693e77c4e9ec5eda5efa2 (patch) | |
| tree | 32cf752999123875fac24b27da13d2d78cd4eddc /ppapi/thunk/ppb_video_decoder_thunk.cc | |
| parent | 5818639c6c590be2290e72706064a6ab4b3b6aad (diff) | |
| download | chromium_src-6ceb1207c32f4ecdd9d693e77c4e9ec5eda5efa2.zip chromium_src-6ceb1207c32f4ecdd9d693e77c4e9ec5eda5efa2.tar.gz chromium_src-6ceb1207c32f4ecdd9d693e77c4e9ec5eda5efa2.tar.bz2 | |
Remove redundant size and type information from VideoDecode PPAPI
The visible size of the video frame is determined at Create stage.
The type of buffer (from system memory or texture-backed via GLES)
is decided by the plugin when it calls AssignGLESBuffers or
AssignSysmemBuffers in response to ProvidePictureBuffers.
The decoded size will be the same as the size requested in
ProvidePictureBuffers.
Thus these values specified anywhere else is redundant, and introduces
a place to have inconsistency.
BUG=NONE
TEST=ovda unittest passes; gles2 runs w/o crashing
Review URL: http://codereview.chromium.org/7021020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93031 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi/thunk/ppb_video_decoder_thunk.cc')
| -rw-r--r-- | ppapi/thunk/ppb_video_decoder_thunk.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/ppapi/thunk/ppb_video_decoder_thunk.cc b/ppapi/thunk/ppb_video_decoder_thunk.cc index afc3bde..f1b7c44 100644 --- a/ppapi/thunk/ppb_video_decoder_thunk.cc +++ b/ppapi/thunk/ppb_video_decoder_thunk.cc @@ -50,12 +50,12 @@ int32_t Decode(PP_Resource video_decoder, return MayForceCallback(callback, result); } -void AssignGLESBuffers(PP_Resource video_decoder, - uint32_t no_of_buffers, - const PP_GLESBuffer_Dev* buffers) { +void AssignPictureBuffers(PP_Resource video_decoder, + uint32_t no_of_buffers, + const PP_PictureBuffer_Dev* buffers) { EnterVideoDecoder enter(video_decoder, true); if (enter.succeeded()) - enter.object()->AssignGLESBuffers(no_of_buffers, buffers); + enter.object()->AssignPictureBuffers(no_of_buffers, buffers); } void ReusePictureBuffer(PP_Resource video_decoder, int32_t picture_buffer_id) { @@ -92,7 +92,7 @@ const PPB_VideoDecoder_Dev g_ppb_videodecoder_thunk = { &IsVideoDecoder, &Initialize, &Decode, - &AssignGLESBuffers, + &AssignPictureBuffers, &ReusePictureBuffer, &Flush, &Reset, |