diff options
author | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-21 21:57:57 +0000 |
---|---|---|
committer | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-21 21:57:57 +0000 |
commit | a3e0815e35fcaa3d8bebde81b74f4a883488c44b (patch) | |
tree | 47d360fedec75eb6738eb83f9b0ff75b35cf3d1b /ppapi | |
parent | 3701b4ea8f21a2bcb4396f59e4b8ee26e8fe7ca4 (diff) | |
download | chromium_src-a3e0815e35fcaa3d8bebde81b74f4a883488c44b.zip chromium_src-a3e0815e35fcaa3d8bebde81b74f4a883488c44b.tar.gz chromium_src-a3e0815e35fcaa3d8bebde81b74f4a883488c44b.tar.bz2 |
Pepper: Fix nits mentioned in review in audio input code.
In particular, dmichael's comments in http://codereview.chromium.org/8574029.
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8489002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111007 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi')
-rw-r--r-- | ppapi/api/trusted/ppb_audio_input_trusted_dev.idl | 21 | ||||
-rw-r--r-- | ppapi/c/trusted/ppb_audio_input_trusted_dev.h | 23 |
2 files changed, 21 insertions, 23 deletions
diff --git a/ppapi/api/trusted/ppb_audio_input_trusted_dev.idl b/ppapi/api/trusted/ppb_audio_input_trusted_dev.idl index 860c2e3..b845ac1 100644 --- a/ppapi/api/trusted/ppb_audio_input_trusted_dev.idl +++ b/ppapi/api/trusted/ppb_audio_input_trusted_dev.idl @@ -11,10 +11,10 @@ label Chrome { }; /** - * This interface is to be used by proxy implementations. All - * functions should be called from the main thread only. The - * resource returned is an Audio input esource; most of the PPB_Audio - * interface is also usable on this resource. + * This interface is to be used by proxy implementations. All functions should + * be called from the main thread only. The resource returned is an Audio input + * resource; most of the PPB_AudioInput interface is also usable on this + * resource. */ [version=0.1, macro="PPB_AUDIO_INPUT_TRUSTED_DEV_INTERFACE"] interface PPB_AudioInputTrusted_Dev { @@ -23,11 +23,10 @@ interface PPB_AudioInputTrusted_Dev { [in] PP_Instance instance); /** - * Opens a paused audio interface, used by trusted side of proxy. - * Returns PP_ERROR_WOULD_BLOCK on success, and invokes - * the |create_callback| asynchronously to complete. - * As this function should always be invoked from the main thread, - * do not use the blocking variant of PP_CompletionCallback. + * Opens a paused audio input interface, used by trusted side of proxy. + * Returns PP_ERROR_WOULD_BLOCK on success, and invokes the |create_callback| + * asynchronously to complete. As this function should always be invoked from + * the main thread, do not use the blocking variant of PP_CompletionCallback. */ int32_t Open( [in] PP_Resource audio_input, @@ -35,7 +34,7 @@ interface PPB_AudioInputTrusted_Dev { [in] PP_CompletionCallback create_callback); /** - * Get the sync socket. Use once Open has completed. + * Get the sync socket. Use once Open has completed. * Returns PP_OK on success. */ int32_t GetSyncSocket( @@ -43,7 +42,7 @@ interface PPB_AudioInputTrusted_Dev { [out] handle_t sync_socket); /** - * Get the shared memory interface. Use once Open has completed. + * Get the shared memory interface. Use once Open has completed. * Returns PP_OK on success. */ int32_t GetSharedMemory( diff --git a/ppapi/c/trusted/ppb_audio_input_trusted_dev.h b/ppapi/c/trusted/ppb_audio_input_trusted_dev.h index bbdb44f..24cc282 100644 --- a/ppapi/c/trusted/ppb_audio_input_trusted_dev.h +++ b/ppapi/c/trusted/ppb_audio_input_trusted_dev.h @@ -3,7 +3,7 @@ * found in the LICENSE file. */ -/* From trusted/ppb_audio_input_trusted_dev.idl modified Mon Nov 14 18:13:23 2011. */ +/* From trusted/ppb_audio_input_trusted_dev.idl modified Mon Nov 21 12:37:35 2011. */ #ifndef PPAPI_C_TRUSTED_PPB_AUDIO_INPUT_TRUSTED_DEV_H_ #define PPAPI_C_TRUSTED_PPB_AUDIO_INPUT_TRUSTED_DEV_H_ @@ -30,31 +30,30 @@ * @{ */ /** - * This interface is to be used by proxy implementations. All - * functions should be called from the main thread only. The - * resource returned is an Audio input esource; most of the PPB_Audio - * interface is also usable on this resource. + * This interface is to be used by proxy implementations. All functions should + * be called from the main thread only. The resource returned is an Audio input + * resource; most of the PPB_AudioInput interface is also usable on this + * resource. */ struct PPB_AudioInputTrusted_Dev { /** Returns an audio input resource. */ PP_Resource (*CreateTrusted)(PP_Instance instance); /** - * Opens a paused audio interface, used by trusted side of proxy. - * Returns PP_ERROR_WOULD_BLOCK on success, and invokes - * the |create_callback| asynchronously to complete. - * As this function should always be invoked from the main thread, - * do not use the blocking variant of PP_CompletionCallback. + * Opens a paused audio input interface, used by trusted side of proxy. + * Returns PP_ERROR_WOULD_BLOCK on success, and invokes the |create_callback| + * asynchronously to complete. As this function should always be invoked from + * the main thread, do not use the blocking variant of PP_CompletionCallback. */ int32_t (*Open)(PP_Resource audio_input, PP_Resource config, struct PP_CompletionCallback create_callback); /** - * Get the sync socket. Use once Open has completed. + * Get the sync socket. Use once Open has completed. * Returns PP_OK on success. */ int32_t (*GetSyncSocket)(PP_Resource audio_input, int* sync_socket); /** - * Get the shared memory interface. Use once Open has completed. + * Get the shared memory interface. Use once Open has completed. * Returns PP_OK on success. */ int32_t (*GetSharedMemory)(PP_Resource audio_input, |