diff options
author | dmichael@chromium.org <dmichael@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-05 22:22:07 +0000 |
---|---|---|
committer | dmichael@chromium.org <dmichael@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-05 22:22:07 +0000 |
commit | 5136ef9734f44432bff484a1aafb603976b26252 (patch) | |
tree | ace8957e98a56b579266b9bb6a5795b127a29b3f /ppapi | |
parent | 1e64f77f677c6a070febe25de93157da3588b5a7 (diff) | |
download | chromium_src-5136ef9734f44432bff484a1aafb603976b26252.zip chromium_src-5136ef9734f44432bff484a1aafb603976b26252.tar.gz chromium_src-5136ef9734f44432bff484a1aafb603976b26252.tar.bz2 |
Merge 212671 "PPAPI: Messaging shouldn't use v8 if Context is empty"
> PPAPI: Messaging shouldn't use v8 if Context is empty
>
> We may sometimes have no valid Context to enter, because the instance is detached from the DOM (which is being destroyed). In that case, we have no way to dispatch a message to JavaScript, so we just drop the message.
>
> BUG=258190
> TEST=See bug 258190 for more information. Install https://chrome.google.com/webstore/detail/chrome-remote-desktop/ajoainacpilcemgiakehflpbkbfipojk (from internal). Launch the Chrome Remote Desktop app. Close it. Launch again and connect to a host. Close it again. Prior to the change, the Chromoting plugin would crash. After this change, it shouldn't.
>
> Review URL: https://chromiumcodereview.appspot.com/18915003
TBR=dmichael@chromium.org
Review URL: https://codereview.chromium.org/22307002
git-svn-id: svn://svn.chromium.org/chrome/branches/1547/src@215707 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi')
-rw-r--r-- | ppapi/tests/test_post_message.cc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/ppapi/tests/test_post_message.cc b/ppapi/tests/test_post_message.cc index 36101fb..b1e30b2 100644 --- a/ppapi/tests/test_post_message.cc +++ b/ppapi/tests/test_post_message.cc @@ -145,6 +145,9 @@ TestPostMessage::TestPostMessage(TestingInstance* instance) } TestPostMessage::~TestPostMessage() { + instance_->PostMessage(pp::Var("This isn't guaranteed to be received, but " + "shouldn't cause a crash.")); + // Remove the special listener that only responds to a FINISHED_WAITING // string. See Init for where it gets added. std::string js_code; |