diff options
| author | pfeldman@chromium.org <pfeldman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-02 04:56:18 +0000 |
|---|---|---|
| committer | pfeldman@chromium.org <pfeldman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-02 04:56:18 +0000 |
| commit | 16578a8e3481ffdde5b699fe747f114efb64a26b (patch) | |
| tree | aded2899b6e2b8c44ed8efdad826a9c2659c173f /ppapi | |
| parent | 1cd6af20ba32d3fc4ebf4290cf25f8fac9bc9c05 (diff) | |
| download | chromium_src-16578a8e3481ffdde5b699fe747f114efb64a26b.zip chromium_src-16578a8e3481ffdde5b699fe747f114efb64a26b.tar.gz chromium_src-16578a8e3481ffdde5b699fe747f114efb64a26b.tar.bz2 | |
Revert of gpu: Raise GL_OUT_OF_MEMORY when BeginQueryEXT fails to allocate. (https://codereview.chromium.org/199443004/)
Reason for revert:
Build failure in content/common/gpu/client/gl_helper_benchmark.cc.
http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/63241/steps/compile/logs/stdio
Original issue's description:
> gpu: Lose context when BeginQueryEXT fails to allocate.
>
> Instead of crashes, raise a GL_OUT_OF_MEMORY error. Since compositor
> does not want to deal with these errors and it would leave it in a
> bad state, add the ability to lose the context when GL_OUT_OF_MEMORY
> occurs.
>
> R=piman
> BUG=351587
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261064
TBR=piman@chromium.org,dmichael@chromium.org,jamesr@chromium.org,danakj@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=351587
Review URL: https://codereview.chromium.org/221783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261075 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi')
| -rw-r--r-- | ppapi/shared_impl/ppb_graphics_3d_shared.cc | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/ppapi/shared_impl/ppb_graphics_3d_shared.cc b/ppapi/shared_impl/ppb_graphics_3d_shared.cc index 1b3677b1..b4e258b 100644 --- a/ppapi/shared_impl/ppb_graphics_3d_shared.cc +++ b/ppapi/shared_impl/ppb_graphics_3d_shared.cc @@ -118,7 +118,6 @@ bool PPB_Graphics3D_Shared::CreateGLES2Impl( transfer_buffer_.reset(new gpu::TransferBuffer(gles2_helper_.get())); const bool bind_creates_resources = true; - const bool lose_context_when_out_of_memory = false; // Create the object exposing the OpenGL API. gles2_impl_.reset(new gpu::gles2::GLES2Implementation( @@ -126,7 +125,6 @@ bool PPB_Graphics3D_Shared::CreateGLES2Impl( share_gles2 ? share_gles2->share_group() : NULL, transfer_buffer_.get(), bind_creates_resources, - lose_context_when_out_of_memory, GetGpuControl())); if (!gles2_impl_->Initialize( |