diff options
| author | yhirano@chromium.org <yhirano@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-24 10:15:05 +0000 |
|---|---|---|
| committer | yhirano@chromium.org <yhirano@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-24 10:15:05 +0000 |
| commit | 7608684092560c7403ca64f5b48c5e23051716ca (patch) | |
| tree | 8867565f86342d6f88909f8a7cad4ff843c8d434 /ppapi | |
| parent | 4f47e7cbb30c265ac985739a601b9a831463425b (diff) | |
| download | chromium_src-7608684092560c7403ca64f5b48c5e23051716ca.zip chromium_src-7608684092560c7403ca64f5b48c5e23051716ca.tar.gz chromium_src-7608684092560c7403ca64f5b48c5e23051716ca.tar.bz2 | |
ThreadedTestRunner::Run contained a PP_DCHECK with a side effect. Some tests failed because of it.
This CL fixes the problem.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/19790011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213386 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi')
| -rw-r--r-- | ppapi/tests/test_case.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/ppapi/tests/test_case.h b/ppapi/tests/test_case.h index 2c81774..4491c76 100644 --- a/ppapi/tests/test_case.h +++ b/ppapi/tests/test_case.h @@ -187,7 +187,9 @@ class TestCase { private: void Run() { - PP_DCHECK(PP_OK == loop_.AttachToCurrentThread()); + int32_t result = loop_.AttachToCurrentThread(); + static_cast<void>(result); // result is not used in the RELEASE build. + PP_DCHECK(PP_OK == result); result_ = (test_case_->*test_to_run_)(); // Now give the loop a chance to clean up. loop_.PostQuit(true /* should_destroy */); |