summaryrefslogtreecommitdiffstats
path: root/ppapi
diff options
context:
space:
mode:
authorerg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-12-07 23:07:27 +0000
committererg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-12-07 23:07:27 +0000
commitaa20e0622a945f94958daa1940385c29779d09e4 (patch)
tree79ba5e11afb6d6edc5a9e4edef95cca4f86467de /ppapi
parent111ca63cacf4cedb65be41fd4cabfa5ad7bb6b86 (diff)
downloadchromium_src-aa20e0622a945f94958daa1940385c29779d09e4.zip
chromium_src-aa20e0622a945f94958daa1940385c29779d09e4.tar.gz
chromium_src-aa20e0622a945f94958daa1940385c29779d09e4.tar.bz2
Move more code from headers to implementation.
BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5624002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68534 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi')
-rw-r--r--ppapi/cpp/paint_aggregator.cc9
-rw-r--r--ppapi/cpp/paint_aggregator.h4
-rw-r--r--ppapi/proxy/plugin_var_tracker.cc2
-rw-r--r--ppapi/proxy/plugin_var_tracker.h2
-rw-r--r--ppapi/proxy/serialized_structs.cc21
-rw-r--r--ppapi/proxy/serialized_structs.h6
6 files changed, 42 insertions, 2 deletions
diff --git a/ppapi/cpp/paint_aggregator.cc b/ppapi/cpp/paint_aggregator.cc
index 7f54331..1138974 100644
--- a/ppapi/cpp/paint_aggregator.cc
+++ b/ppapi/cpp/paint_aggregator.cc
@@ -25,8 +25,13 @@
namespace pp {
-PaintAggregator::InternalPaintUpdate::InternalPaintUpdate() {
-}
+PaintAggregator::PaintUpdate::PaintUpdate() {}
+
+PaintAggregator::PaintUpdate::~PaintUpdate() {}
+
+PaintAggregator::InternalPaintUpdate::InternalPaintUpdate() {}
+
+PaintAggregator::InternalPaintUpdate::~InternalPaintUpdate() {}
Rect PaintAggregator::InternalPaintUpdate::GetScrollDamage() const {
// Should only be scrolling in one direction at a time.
diff --git a/ppapi/cpp/paint_aggregator.h b/ppapi/cpp/paint_aggregator.h
index a73a998..3fe32a5 100644
--- a/ppapi/cpp/paint_aggregator.h
+++ b/ppapi/cpp/paint_aggregator.h
@@ -22,6 +22,9 @@ namespace pp {
class PaintAggregator {
public:
struct PaintUpdate {
+ PaintUpdate();
+ ~PaintUpdate();
+
// True if there is a scroll applied. This indicates that the scroll delta
// and scroll_rect are nonzero (just as a convenience).
bool has_scroll;
@@ -86,6 +89,7 @@ class PaintAggregator {
class InternalPaintUpdate {
public:
InternalPaintUpdate();
+ ~InternalPaintUpdate();
// Computes the rect damaged by scrolling within |scroll_rect| by
// |scroll_delta|. This rect must be repainted. It is not included in
diff --git a/ppapi/proxy/plugin_var_tracker.cc b/ppapi/proxy/plugin_var_tracker.cc
index dabdf8f..f2bc5975 100644
--- a/ppapi/proxy/plugin_var_tracker.cc
+++ b/ppapi/proxy/plugin_var_tracker.cc
@@ -42,6 +42,8 @@ PluginVarTracker::PluginVarTracker(PluginDispatcher* dispatcher)
: dispatcher_(dispatcher) {
}
+PluginVarTracker::~PluginVarTracker() {}
+
int64 PluginVarTracker::MakeString(const std::string& str) {
RefCountedString* out = new RefCountedString(str);
out->AddRef();
diff --git a/ppapi/proxy/plugin_var_tracker.h b/ppapi/proxy/plugin_var_tracker.h
index 1ae5b24..999f209 100644
--- a/ppapi/proxy/plugin_var_tracker.h
+++ b/ppapi/proxy/plugin_var_tracker.h
@@ -30,6 +30,8 @@ class PluginVarTracker {
// which is probably just being created from our constructor.
PluginVarTracker(PluginDispatcher* dispatcher);
+ ~PluginVarTracker();
+
// Must be called after construction.
void Init();
diff --git a/ppapi/proxy/serialized_structs.cc b/ppapi/proxy/serialized_structs.cc
index fa71f71..ab33bab 100644
--- a/ppapi/proxy/serialized_structs.cc
+++ b/ppapi/proxy/serialized_structs.cc
@@ -10,6 +10,19 @@
namespace pp {
namespace proxy {
+SerializedFontDescription::SerializedFontDescription()
+ : face(),
+ family(0),
+ size(0),
+ weight(0),
+ italic(PP_FALSE),
+ small_caps(PP_FALSE),
+ letter_spacing(0),
+ word_spacing(0) {
+}
+
+SerializedFontDescription::~SerializedFontDescription() {}
+
void SerializedFontDescription::SetFromPPFontDescription(
Dispatcher* dispatcher,
const PP_FontDescription_Dev& desc,
@@ -49,5 +62,13 @@ void SerializedFontDescription::SetToPPFontDescription(
desc->word_spacing = word_spacing;
}
+PPBFlash_DrawGlyphs_Params::PPBFlash_DrawGlyphs_Params()
+ : pp_image_data(0),
+ font_desc(),
+ color(0) {
+}
+
+PPBFlash_DrawGlyphs_Params::~PPBFlash_DrawGlyphs_Params() {}
+
} // namespace proxy
} // namespace pp
diff --git a/ppapi/proxy/serialized_structs.h b/ppapi/proxy/serialized_structs.h
index 49fc222..d90926b 100644
--- a/ppapi/proxy/serialized_structs.h
+++ b/ppapi/proxy/serialized_structs.h
@@ -24,6 +24,9 @@ class Dispatcher;
// PP_FontDescript_Dev has to be redefined with a SerializedVar in place of
// the PP_Var used for the face name.
struct SerializedFontDescription {
+ SerializedFontDescription();
+ ~SerializedFontDescription();
+
// Converts a PP_FontDescription_Dev to a SerializedFontDescription.
//
// If source_owns_ref is true, the reference owned by the
@@ -80,6 +83,9 @@ struct PPBFont_DrawTextAt_Params {
};
struct PPBFlash_DrawGlyphs_Params {
+ PPBFlash_DrawGlyphs_Params();
+ ~PPBFlash_DrawGlyphs_Params();
+
PP_Resource pp_image_data;
SerializedFontDescription font_desc;
uint32_t color;