diff options
| author | piman@chromium.org <piman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-15 14:22:37 +0000 |
|---|---|---|
| committer | piman@chromium.org <piman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-15 14:22:37 +0000 |
| commit | 64ba52f03b2936af0e6b924417ca8f29958b473e (patch) | |
| tree | 62d4f2e60903550e97c618f9074ec92340bfe3f2 /ppapi | |
| parent | b5641b965afa45a0c0a1e85a669935e9150ec9f0 (diff) | |
| download | chromium_src-64ba52f03b2936af0e6b924417ca8f29958b473e.zip chromium_src-64ba52f03b2936af0e6b924417ca8f29958b473e.tar.gz chromium_src-64ba52f03b2936af0e6b924417ca8f29958b473e.tar.bz2 | |
gpu: Generate mailboxes on client side
Because mailboxes are now just a random number, we don't need to round-trip to
the gpu process to generate them, which lets us get rid of IPCs, layers, etc.
It also means generating a mailbox can't fail any more (even on a lost context),
so, removing some code paths and associated tests.
I'm adding a debug-only verification to ensure the mailboxes are generated from
the crypto-random function (in debug, we burn a byte to compute a mini XOR-check
as a sentinel for "we went through the Generate function"). It's not a secure
check, but should hit incorrect/unsafe usage.
BUG=None
Review URL: https://codereview.chromium.org/165393003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251570 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi')
| -rw-r--r-- | ppapi/proxy/ppapi_command_buffer_proxy.cc | 9 | ||||
| -rw-r--r-- | ppapi/proxy/ppapi_command_buffer_proxy.h | 2 |
2 files changed, 0 insertions, 11 deletions
diff --git a/ppapi/proxy/ppapi_command_buffer_proxy.cc b/ppapi/proxy/ppapi_command_buffer_proxy.cc index c2f74e2..6d9a0ae 100644 --- a/ppapi/proxy/ppapi_command_buffer_proxy.cc +++ b/ppapi/proxy/ppapi_command_buffer_proxy.cc @@ -250,15 +250,6 @@ void PpapiCommandBufferProxy::DestroyGpuMemoryBuffer(int32 id) { NOTREACHED(); } -bool PpapiCommandBufferProxy::GenerateMailboxNames( - unsigned num, std::vector<gpu::Mailbox>* names) { - // TODO(piman): implement this so we can expose mailboxes to pepper - // eventually. - NOTREACHED(); - return false; -} - - bool PpapiCommandBufferProxy::Send(IPC::Message* msg) { DCHECK(last_state_.error == gpu::error::kNoError); diff --git a/ppapi/proxy/ppapi_command_buffer_proxy.h b/ppapi/proxy/ppapi_command_buffer_proxy.h index 36d23ea..863ffd4 100644 --- a/ppapi/proxy/ppapi_command_buffer_proxy.h +++ b/ppapi/proxy/ppapi_command_buffer_proxy.h @@ -53,8 +53,6 @@ class PPAPI_PROXY_EXPORT PpapiCommandBufferProxy : public gpu::CommandBuffer, unsigned internalformat, int32* id) OVERRIDE; virtual void DestroyGpuMemoryBuffer(int32 id) OVERRIDE; - virtual bool GenerateMailboxNames(unsigned num, - std::vector<gpu::Mailbox>* names) OVERRIDE; virtual uint32 InsertSyncPoint() OVERRIDE; virtual void SignalSyncPoint(uint32 sync_point, const base::Closure& callback) OVERRIDE; |