diff options
| author | mcgrathr@chromium.org <mcgrathr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-05 23:07:23 +0000 |
|---|---|---|
| committer | mcgrathr@chromium.org <mcgrathr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-05 23:07:23 +0000 |
| commit | 7dfbeb4e81423b8032d59714578894cb462bb8c3 (patch) | |
| tree | 0c7cd440c6939c9d53c7e5bcdbd927ea1daf5bce /ppapi | |
| parent | 0cff7511e9aba47dc22f16287148f26cec36a93d (diff) | |
| download | chromium_src-7dfbeb4e81423b8032d59714578894cb462bb8c3.zip chromium_src-7dfbeb4e81423b8032d59714578894cb462bb8c3.tar.gz chromium_src-7dfbeb4e81423b8032d59714578894cb462bb8c3.tar.bz2 | |
IWYU and nit warning fixes for some NaCl PPAPI tests
Newer compilers have new warnings: signedness of integer initializers matters.
Newer libstdc++ reduces implicit #include's so IWYU failures get noticed:
usleep is declared in <unistd.h>.
BUG= none
TEST= nacl_integration
R=sehr@google.com
Review URL: https://chromiumcodereview.appspot.com/10545012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140643 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi')
3 files changed, 7 insertions, 5 deletions
diff --git a/ppapi/native_client/tests/ppapi_browser/crash/ppapi_crash_off_main_thread.cc b/ppapi/native_client/tests/ppapi_browser/crash/ppapi_crash_off_main_thread.cc index c604932..5204255 100644 --- a/ppapi/native_client/tests/ppapi_browser/crash/ppapi_crash_off_main_thread.cc +++ b/ppapi/native_client/tests/ppapi_browser/crash/ppapi_crash_off_main_thread.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. // @@ -6,6 +6,7 @@ #include <pthread.h> #include <stdio.h> +#include <unistd.h> #include "native_client/src/shared/platform/nacl_check.h" #include "native_client/tests/ppapi_test_lib/test_interface.h" diff --git a/ppapi/native_client/tests/ppapi_browser/ppb_core/ppapi_ppb_core.cc b/ppapi/native_client/tests/ppapi_browser/ppb_core/ppapi_ppb_core.cc index b944132..b683b17 100644 --- a/ppapi/native_client/tests/ppapi_browser/ppb_core/ppapi_ppb_core.cc +++ b/ppapi/native_client/tests/ppapi_browser/ppb_core/ppapi_ppb_core.cc @@ -1,10 +1,11 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include <pthread.h> #include <stdio.h> #include <string.h> +#include <unistd.h> #include "native_client/src/shared/platform/nacl_check.h" #include "native_client/tests/ppapi_test_lib/get_browser_interface.h" diff --git a/ppapi/native_client/tests/ppapi_browser/ppb_scrollbar/ppapi_ppb_scrollbar.cc b/ppapi/native_client/tests/ppapi_browser/ppb_scrollbar/ppapi_ppb_scrollbar.cc index 3a64d24..0f7f6fb 100644 --- a/ppapi/native_client/tests/ppapi_browser/ppb_scrollbar/ppapi_ppb_scrollbar.cc +++ b/ppapi/native_client/tests/ppapi_browser/ppb_scrollbar/ppapi_ppb_scrollbar.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -116,7 +116,8 @@ void TestScrollBy() { void TestSetTickMarks() { PP_Resource scrollbar = PPBScrollbarDev()->Create(pp_instance(), kVertical); - uint32_t thickness = PPBScrollbarDev()->GetThickness(scrollbar); + // GetThickness returns uint32_t, but PP_Rect initializers must be int32_t. + int32_t thickness = PPBScrollbarDev()->GetThickness(scrollbar); const int32_t kCount = 2; PP_Rect tick_marks[kCount] = { { {0, 0}, {thickness, 1} }, @@ -142,4 +143,3 @@ void SetupTests() { void SetupPluginInterfaces() { } - |