diff options
| author | wez@chromium.org <wez@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-21 03:24:34 +0000 |
|---|---|---|
| committer | wez@chromium.org <wez@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-21 03:24:34 +0000 |
| commit | e12f4ccb55fe0589987464f15ab637b8d436db86 (patch) | |
| tree | a11468ddbe98efd418112672e40ca8f357776a4f /ppapi | |
| parent | c985a1a77827f77dc81edf36ac547d09f35a2caf (diff) | |
| download | chromium_src-e12f4ccb55fe0589987464f15ab637b8d436db86.zip chromium_src-e12f4ccb55fe0589987464f15ab637b8d436db86.tar.gz chromium_src-e12f4ccb55fe0589987464f15ab637b8d436db86.tar.bz2 | |
Add presubmit exception for PPAPI_RELEASE changes to pp_macros.h
The C header generator adds a PPAPI_RELEASE macro based on all the
IDL files, so pp_macros.h may change while its IDL does not.
Review URL: https://chromiumcodereview.appspot.com/12317032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183729 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi')
| -rw-r--r-- | ppapi/PRESUBMIT.py | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/ppapi/PRESUBMIT.py b/ppapi/PRESUBMIT.py index 57278e2..42a781a 100644 --- a/ppapi/PRESUBMIT.py +++ b/ppapi/PRESUBMIT.py @@ -166,6 +166,22 @@ def CheckChange(input_api, output_api): if filename not in set(idl_files): name_parts = filename.split(os.sep) + if name_parts[-1] == 'pp_macros': + # The C header generator adds a PPAPI_RELEASE macro based on all the + # IDL files, so pp_macros.h may change while its IDL does not. + lines = input_api.RightHandSideLines( + lambda f: f.LocalPath() == 'ppapi/c/%s.h' % filename) + releaseChanged = False + for line in lines: + if line[2].split()[:2] == ['#define', 'PPAPI_RELEASE']: + results.append( + output_api.PresubmitPromptWarning( + 'PPAPI_RELEASE has changed', long_text=line[2])) + releaseChanged = True + break + if releaseChanged: + continue + if 'trusted' in name_parts: missing_priv.append(' ppapi/c/%s.h' % filename) continue |