diff options
| author | brettw <brettw@chromium.org> | 2015-07-27 12:45:25 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-27 19:46:54 +0000 |
| commit | 8f3218985dde74063ccc362da47803be163f3165 (patch) | |
| tree | 177bd60384bfb8dc03fe439e82ff6f6061fdf59a /ppapi | |
| parent | 258deb0a1977629e17c135a03080061ef9d1535b (diff) | |
| download | chromium_src-8f3218985dde74063ccc362da47803be163f3165.zip chromium_src-8f3218985dde74063ccc362da47803be163f3165.tar.gz chromium_src-8f3218985dde74063ccc362da47803be163f3165.tar.bz2 | |
Add precompiled headers to GN build for large targets.
Turns on precompiled header support in the GN build on Windows, and adds the precompiled header config to most large-ish targets in the build.
Removes Windows files from the precompiled header. This does not seem to affect the build speed much because most Chrome files don't depend on Windows any more. And windows.h injects typedefs and defines that conflict with some third party libraries and prevent using precompiled headers for those targets or any target that includes them.
I counted ~50 files or bigger as large. The 50 file threshold is based on some previous approximate measurements (since the precompile step is an extra per-target compile, it can actually make small targets compile slower).
For borderline cases, I added the precompiled header flag if I thought it was likely to have more files added, and didn't add it if I thought the target was likely to be static.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1250273002
Cr-Commit-Position: refs/heads/master@{#340535}
Diffstat (limited to 'ppapi')
| -rw-r--r-- | ppapi/BUILD.gn | 1 | ||||
| -rw-r--r-- | ppapi/cpp/BUILD.gn | 1 | ||||
| -rw-r--r-- | ppapi/proxy/BUILD.gn | 5 | ||||
| -rw-r--r-- | ppapi/shared_impl/BUILD.gn | 1 | ||||
| -rw-r--r-- | ppapi/thunk/BUILD.gn | 1 |
5 files changed, 8 insertions, 1 deletions
diff --git a/ppapi/BUILD.gn b/ppapi/BUILD.gn index ae8b8b7..d14ad70 100644 --- a/ppapi/BUILD.gn +++ b/ppapi/BUILD.gn @@ -34,6 +34,7 @@ shared_library("ppapi_tests") { sources = ppapi_sources.test_common_source_files + ppapi_sources.test_trusted_source_files + configs += [ "//build/config:precompiled_headers" ] defines = [ "GL_GLEXT_PROTOTYPES" ] include_dirs = [ "lib/gl/include" ] diff --git a/ppapi/cpp/BUILD.gn b/ppapi/cpp/BUILD.gn index 2e121be..63b3f60 100644 --- a/ppapi/cpp/BUILD.gn +++ b/ppapi/cpp/BUILD.gn @@ -23,4 +23,5 @@ source_set("cpp") { # themselves. source_set("objects") { sources = rebase_path(ppapi_sources.cpp_source_files, ".", "..") + configs += [ "//build/config:precompiled_headers" ] } diff --git a/ppapi/proxy/BUILD.gn b/ppapi/proxy/BUILD.gn index 62a5370..bd378d5 100644 --- a/ppapi/proxy/BUILD.gn +++ b/ppapi/proxy/BUILD.gn @@ -265,7 +265,10 @@ component("proxy") { ] } - configs += [ ":proxy_implementation" ] + configs += [ + ":proxy_implementation", + "//build/config:precompiled_headers", + ] deps = [ "//base", diff --git a/ppapi/shared_impl/BUILD.gn b/ppapi/shared_impl/BUILD.gn index 9d205ec..25ad904 100644 --- a/ppapi/shared_impl/BUILD.gn +++ b/ppapi/shared_impl/BUILD.gn @@ -151,6 +151,7 @@ component("shared_impl") { ] } + configs += [ "//build/config:precompiled_headers" ] defines = [ "PPAPI_SHARED_IMPLEMENTATION", diff --git a/ppapi/thunk/BUILD.gn b/ppapi/thunk/BUILD.gn index c62534f..b4adef9 100644 --- a/ppapi/thunk/BUILD.gn +++ b/ppapi/thunk/BUILD.gn @@ -187,6 +187,7 @@ source_set("thunk") { ] } + configs += [ "//build/config:precompiled_headers" ] defines = [ # This target goes in the same library as shared_impl (in GYP they are the # same). |