diff options
| author | yzshen@chromium.org <yzshen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-14 21:49:37 +0000 |
|---|---|---|
| committer | yzshen@chromium.org <yzshen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-14 21:49:37 +0000 |
| commit | 8a82c536e6aed717bdb179fa52d0a88f76c809b7 (patch) | |
| tree | ac794953b5903274b474e21dde13a9d048e2b004 /ppapi | |
| parent | bd917c83eba3fa9d4e637c71078073230b71ad90 (diff) | |
| download | chromium_src-8a82c536e6aed717bdb179fa52d0a88f76c809b7.zip chromium_src-8a82c536e6aed717bdb179fa52d0a88f76c809b7.tar.gz chromium_src-8a82c536e6aed717bdb179fa52d0a88f76c809b7.tar.bz2 | |
Revert 167312 - Add CHECKs to diagnose a Pepper Flash crash.
Sometimes Flash receives a 0 device scale value, we would like to find out in what circumstances the renderer side would send such a value.
This CL will be removed after it takes effect in one Canary build.
BUG=156730
TEST=None
Review URL: https://codereview.chromium.org/11360212
TBR=yzshen@chromium.org
Review URL: https://codereview.chromium.org/11365267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167753 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ppapi')
| -rw-r--r-- | ppapi/proxy/ppp_instance_proxy.cc | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/ppapi/proxy/ppp_instance_proxy.cc b/ppapi/proxy/ppp_instance_proxy.cc index ff52d68..bfc9102 100644 --- a/ppapi/proxy/ppp_instance_proxy.cc +++ b/ppapi/proxy/ppp_instance_proxy.cc @@ -70,13 +70,6 @@ void DidChangeView(PP_Instance instance, PP_Resource view_resource) { return; } - // TODO(yzshen): For debugging crbug.com/156730. According to the crash - // report, sometimes the plugin side receives a ViewData object with mostly - // default values, e.g., device_scale is set to 0. We crash here to find out - // in what circumstances the renderer side would send such a value. - // Must be revomved on the next day. - CHECK(enter.object()->GetData().device_scale > 0.0f); - dispatcher->Send(new PpapiMsg_PPPInstance_DidChangeView( API_ID_PPP_INSTANCE, instance, enter.object()->GetData(), IsFlashFullscreen(instance, dispatcher))); |