diff options
author | mseaborn <mseaborn@chromium.org> | 2015-12-21 20:47:53 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-12-22 04:48:48 +0000 |
commit | 38c234c3dd8008ebf47bd81a63f815ae4bd0d007 (patch) | |
tree | 79ae67b1d4978ca49fdf77a98fb343e7b2495e86 /ppapi | |
parent | ad29c15e3115a256cec6ee0ab0ba3138ef087569 (diff) | |
download | chromium_src-38c234c3dd8008ebf47bd81a63f815ae4bd0d007.zip chromium_src-38c234c3dd8008ebf47bd81a63f815ae4bd0d007.tar.gz chromium_src-38c234c3dd8008ebf47bd81a63f815ae4bd0d007.tar.bz2 |
NaCl: Expand comment about PpapiHostMsg_OpenResource in ppapi_messages.h
BUG=302078
TEST=none
Review URL: https://codereview.chromium.org/1540953002
Cr-Commit-Position: refs/heads/master@{#366543}
Diffstat (limited to 'ppapi')
-rw-r--r-- | ppapi/proxy/ppapi_messages.h | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/ppapi/proxy/ppapi_messages.h b/ppapi/proxy/ppapi_messages.h index 3bc0d5f..c332a9d 100644 --- a/ppapi/proxy/ppapi_messages.h +++ b/ppapi/proxy/ppapi_messages.h @@ -884,7 +884,20 @@ IPC_MESSAGE_CONTROL1(PpapiHostMsg_ChannelCreated, // Notify the renderer that the PPAPI channel gets ready in the plugin. IPC_MESSAGE_CONTROL0(PpapiHostMsg_StartupInitializationComplete) -// Calls renderer to open a resource file for nacl_irt_open_resource(). +// This is sent from a nexe (NaCl untrusted code) to the renderer, to open a +// file listed in a NaCl manifest file (NMF). It is part of the +// implementation of open_resource(), which is defined in NaCl's irt.h. +// +// This call returns a read-only file handle from the renderer. When using +// validation caching, this handle is not used: The NaCl loader process will +// reacquire the handle from the more-trusted browser process via +// NaClProcessMsg_ResolveFileToken, passing the token values returned here. +// +// Note that the open_resource() interface is not a PPAPI interface (in the +// sense that it's not defined in ppapi/c/), but this message is defined here +// in ppapi_messages.h (rather than in components/nacl/) because half of the +// implementation of open_resource() lives in ppapi/nacl_irt/, and because +// this message must be processed by ppapi/proxy/nacl_message_scanner.cc. IPC_SYNC_MESSAGE_CONTROL1_3(PpapiHostMsg_OpenResource, std::string /* key */, ppapi::proxy::SerializedHandle /* fd */, |