diff options
| author | mukai@chromium.org <mukai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-10 07:40:50 +0000 |
|---|---|---|
| committer | mukai@chromium.org <mukai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-10 07:40:50 +0000 |
| commit | a5a068d6d14a8e99e047a323485516cfa07bd5eb (patch) | |
| tree | 0b65a9ab8b7d425dad553079f8b9a3639ab3eeee /printing/printing.gyp | |
| parent | 9bd9fc06e4d7f9ebe3594789c6bca8d8cf995dd7 (diff) | |
| download | chromium_src-a5a068d6d14a8e99e047a323485516cfa07bd5eb.zip chromium_src-a5a068d6d14a8e99e047a323485516cfa07bd5eb.tar.gz chromium_src-a5a068d6d14a8e99e047a323485516cfa07bd5eb.tar.bz2 | |
Separate the logic of popup alignment and workarea handling as delegate.
MessagePopupCollection contains plenty size of conditions and ifdefs
to work properly with each type of the desktop we have, and some
logic makes side effects on another desktop. This design is unhealty
and adding more conditions sounds incorrect.
Considering this, it would be better to extract platform dependent
parts as a delegate class (PopupAlignmentDelegate) and allow
subclasses to provide platform-specific features.
This design is also beneficial for win-ash, because we had
OS_CHROMEOS layout data and logic which actually means Ash.
BUG=389656
R=stevenjb@chromium.org, dimich@chromium.org
TBR=jamescook@chromium.org, harrym@chromium.org
TEST=message_center_unittests, ash_unittests, some manual checks
Review URL: https://codereview.chromium.org/369573004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282269 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'printing/printing.gyp')
0 files changed, 0 insertions, 0 deletions